Skip to content

Update config.sample.php improving description for key apps_path#30903

Merged
PVince81 merged 1 commit into
masterfrom
config_sample_php_apps_path
Apr 10, 2018
Merged

Update config.sample.php improving description for key apps_path#30903
PVince81 merged 1 commit into
masterfrom
config_sample_php_apps_path

Conversation

@mmattel

@mmattel mmattel commented Mar 26, 2018

Copy link
Copy Markdown
Contributor

Description

This is a small update of config.sample.php to improve the description for the apps_path key.
Link to PR #30889 (Add per default the apps2 directory in config.php during installation) for completeness.

Related Issue

Motivation and Context

Better understanding what the key does plus improved example.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@settermjd, I was not able to get the script running you mentioned in owncloud-archive/documentation#3934 . It always complains about the paths. Can you pls help to create the documentation version of config.sample.php?

@mmattel
mmattel requested review from PVince81 and cdamken March 26, 2018 05:34
@codecov

codecov Bot commented Mar 26, 2018

Copy link
Copy Markdown

Codecov Report

Merging #30903 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #30903   +/-   ##
=========================================
  Coverage     62.45%   62.45%           
  Complexity    18230    18230           
=========================================
  Files          1145     1145           
  Lines         68276    68276           
  Branches       1234     1234           
=========================================
  Hits          42641    42641           
  Misses        25274    25274           
  Partials        361      361
Flag Coverage Δ Complexity Δ
#javascript 52% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.64% <ø> (ø) 18230 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8862fe3...c6029a0. Read the comment docs.

@DeepDiver1975

Copy link
Copy Markdown
Member

@settermjd please have a look - doc relevant - THX

@mmattel
mmattel force-pushed the config_sample_php_apps_path branch from f20e5bc to c6029a0 Compare April 9, 2018 07:30
@mmattel

mmattel commented Apr 9, 2018

Copy link
Copy Markdown
Contributor Author

Because of a requested name change of the directory name from apps2 to apps-external in #30889, I synced the naming in this PR to be inline.

This PR is independent to the refrenced PR ! because it just describes the functionality.

@settermjd settermjd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Docs will be updated when it's merged and backported.

@felixboehm felixboehm modified the milestones: development, planned Apr 10, 2018
@PVince81
PVince81 merged commit b9ec16d into master Apr 10, 2018
@PVince81
PVince81 deleted the config_sample_php_apps_path branch April 10, 2018 09:12
mmattel pushed a commit that referenced this pull request Apr 10, 2018
…apps_path

Update config.sample.php improving description for key apps_path
@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@lock

lock Bot commented Jul 31, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants