[forward_port] Verify checksums command

[IljaN]

Forward port of #31008

[codecov]

Codecov Report

Merging #31082 into master will increase coverage by 0.03%.
The diff coverage is 85.05%.

@@             Coverage Diff              @@
##             master   #31082      +/-   ##
============================================
+ Coverage     62.47%    62.5%   +0.03%     
- Complexity    18237    18268      +31     
============================================
  Files          1145     1146       +1     
  Lines         68313    68397      +84     
  Branches       1234     1234              
============================================
+ Hits          42678    42753      +75     
- Misses        25274    25283       +9     
  Partials        361      361

Flag	Coverage Δ	Complexity Δ
#javascript	52.03% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	63.7% <85.05%> (+0.03%)	18268 <26> (+31)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Files/Storage/Wrapper/Checksum.php	100% <100%> (ø)	23 <0> (ø)	⬇️
lib/private/Files/Cache/Scanner.php	86.47% <100%> (+0.19%)	114 <0> (+3)	⬆️
lib/private/Files/ObjectStore/NoopScanner.php	61.53% <50%> (-5.13%)	5 <0> (+2)
apps/files/lib/Command/VerifyChecksums.php	85.71% <85.71%> (ø)	26 <26> (?)
lib/private/Files/Node/Node.php	86.76% <0%> (+1.47%)	62% <0%> (ø)	⬇️
lib/private/Files/Node/File.php	95.65% <0%> (+2.89%)	32% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e44172...2846d98. Read the comment docs.

[PVince81]

👍

[mrow4a]

Hey @IljaN @PVince81 you removed that unit test, but did you cover that logic with another unit test? Where do you unit test condition to clear the checksum?

[IljaN]

The checksum must not be cleared anymore, the checksum wrapper recalculates the new checksum on file_put_contents. The above tests is from the old checksum impl. where the client just sent some checksum and it got written to the db without any checks.

[IljaN]

Tests are here: https://github.com/owncloud/core/edit/mutex_for_checksum_stream/tests/lib/Files/Storage/Wrapper/ChecksumTest.php?pr=/owncloud/core/pull/31102

Checksums are also covered by acceptance tests:

core/tests/acceptance/features/apiMain/checksums.feature

Line 2 in 7bc9eae

Feature: checksums

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.