Revert "[stable10] Retry chunks in web UI on stalled uploads"#31185
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## stable10 #31185 +/- ##
==============================================
+ Coverage 60.22% 60.22% +<.01%
Complexity 18188 18188
==============================================
Files 1194 1194
Lines 71777 71773 -4
Branches 1248 1248
==============================================
- Hits 43230 43228 -2
+ Misses 28177 28175 -2
Partials 370 370
Continue to review full report at Codecov.
|
DeepDiver1975
approved these changes
Apr 18, 2018
29 tasks
1 task
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #31005
This somehow stopped working on 10.0.8 RC2 or I'm really unlucky with testing.
Every upload now shows a message that the chunk sizes do not sum up to the expected value when at least one chunk got retried.
As I have no time to dig deeper, let's revert this on stable10 and investigate for 10.0.9.
As discussed with @pmaier1