Login test user to enforce storage creation

[DeepDiver1975]

Description

Test requires change in order to let files_primary_s3 test run properly - see owncloud/files_primary_s3#75

Failing acceptance tests can be ignore at the moment.

How Has This Been Tested?

• unit tests execution in here
• unit tests execution in Run tests with different core branch files_primary_s3#75

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #31635 into master will increase coverage by 0.21%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #31635      +/-   ##
============================================
+ Coverage     62.91%   63.12%   +0.21%     
  Complexity    18424    18424              
============================================
  Files          1156     1156              
  Lines         69184    69216      +32     
  Branches       1260     1260              
============================================
+ Hits          43527    43693     +166     
+ Misses        25288    25154     -134     
  Partials        369      369

Flag	Coverage Δ	Complexity Δ
#javascript	52.39% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	64.35% <ø> (+0.23%)	18424 <ø> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Files/Cache/HomePropagator.php	77.77% <0%> (-9.73%)	3% <0%> (ø)
apps/files/lib/Command/Scan.php	71.42% <0%> (-9.15%)	72% <0%> (ø)
lib/private/Installer.php	46.92% <0%> (-8.78%)	87% <0%> (ø)
lib/private/legacy/app.php	64.31% <0%> (-0.23%)	180% <0%> (ø)
apps/dav/lib/Connector/Sabre/File.php	85.95% <0%> (+0.66%)	112% <0%> (ø)	⬇️
apps/files_versions/lib/Storage.php	71.39% <0%> (+2.4%)	104% <0%> (ø)	⬇️
lib/private/legacy/util.php	70.54% <0%> (+2.49%)	246% <0%> (ø)	⬇️
lib/private/Files/Storage/Common.php	84.31% <0%> (+3.59%)	135% <0%> (ø)	⬇️
apps/files_trashbin/lib/Quota.php	92% <0%> (+4%)	9% <0%> (ø)	⬇️
lib/private/Files/Cache/Storage.php	86.2% <0%> (+4.59%)	32% <0%> (ø)	⬇️
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaa2f39...4950f87. Read the comment docs.

[phil-davis]

files is duplicated.

[DeepDiver1975]

THX - fixed

[patrickjahns]

Needed to install core before installing objectstore app to be able to execute commands

Not sure if testing app modifies any behavior in core for unit testing - can you confirm @phil-davis @DeepDiver1975 @PVince81

I am also not very happy that INSTALL_SERVER: true needed to be added to all unit tests - it's 3 steps that don't need core to be installed (linting / code compliance / javascript) - maybe @tboerger has a better idea on how to do this

edit: talked with @tboerger - best way of managing this currently :'(

[PVince81]

As far as I remember the testing app only modifies things for acceptance tests, not unit tests

[patrickjahns]

increased coverage 💪

[patrickjahns]

LGTM

[patrickjahns]

backport of drone changes required to always test files_primary_S3 on core

[phil-davis]

@DeepDiver1975 another backport waiting to be done. I guess the backport would be good to get in the nightly image build.

[DeepDiver1975]

backport is in #31050

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.