Skip to content

Exceptions need to properly be handled in the preview plugin#31749

Merged
DeepDiver1975 merged 2 commits into
masterfrom
master-c479aad2f3b176ea0840300b08c2ab7d65f3484b
Jun 14, 2018
Merged

Exceptions need to properly be handled in the preview plugin#31749
DeepDiver1975 merged 2 commits into
masterfrom
master-c479aad2f3b176ea0840300b08c2ab7d65f3484b

Conversation

@DeepDiver1975

Copy link
Copy Markdown
Member

port of #31748

@DeepDiver1975 DeepDiver1975 added this to the development milestone Jun 13, 2018
@DeepDiver1975 DeepDiver1975 self-assigned this Jun 13, 2018
@DeepDiver1975

Copy link
Copy Markdown
Member Author

PHP cs ..... Will take care

@DeepDiver1975 DeepDiver1975 force-pushed the master-c479aad2f3b176ea0840300b08c2ab7d65f3484b branch from 1832ace to 3d77da1 Compare June 13, 2018 19:36
@codecov

codecov Bot commented Jun 13, 2018

Copy link
Copy Markdown

Codecov Report

Merging #31749 into master will increase coverage by 0.02%.
The diff coverage is 96.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #31749      +/-   ##
============================================
+ Coverage     63.17%    63.2%   +0.02%     
- Complexity    18448    18451       +3     
============================================
  Files          1158     1158              
  Lines         69294    69299       +5     
  Branches       1261     1261              
============================================
+ Hits          43776    43798      +22     
+ Misses        25148    25131      -17     
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.47% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.43% <96.42%> (+0.03%) 18451 <1> (+3) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/Server.php 51.07% <100%> (ø) 24 <0> (ø) ⬇️
apps/dav/lib/Files/PreviewPlugin.php 90.9% <96.29%> (+44.75%) 15 <1> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 742d088...32c82f8. Read the comment docs.

@DeepDiver1975

Copy link
Copy Markdown
Member Author

#31748 is merged - merging this as well

@DeepDiver1975 DeepDiver1975 merged commit d3841cf into master Jun 14, 2018
@DeepDiver1975 DeepDiver1975 deleted the master-c479aad2f3b176ea0840300b08c2ab7d65f3484b branch June 14, 2018 12:13
@lock

lock Bot commented Jul 30, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant