Skip to content

Add litmus test on mounted storage and shared folder#32311

Merged
patrickjahns merged 1 commit into
masterfrom
feature/run-litmus-in-shared-folder
Aug 16, 2018
Merged

Add litmus test on mounted storage and shared folder#32311
patrickjahns merged 1 commit into
masterfrom
feature/run-litmus-in-shared-folder

Conversation

@DeepDiver1975

@DeepDiver1975 DeepDiver1975 commented Aug 13, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Description

We shall run litmus tests on

  • shared folder
  • mounted folder

Related Issue

refs #31651

Motivation and Context

the webdav behavior has to be the same on mounted and shared folders

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@DeepDiver1975 DeepDiver1975 added this to the development milestone Aug 13, 2018
@DeepDiver1975 DeepDiver1975 self-assigned this Aug 13, 2018
@DeepDiver1975 DeepDiver1975 force-pushed the feature/run-litmus-in-shared-folder branch 2 times, most recently from b132567 to 1628c6d Compare August 13, 2018 10:03
@codecov

codecov Bot commented Aug 13, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #32311 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #32311   +/-   ##
=========================================
  Coverage     64.01%   64.01%           
  Complexity    18561    18561           
=========================================
  Files          1171     1171           
  Lines         69843    69843           
  Branches       1267     1267           
=========================================
  Hits          44713    44713           
  Misses        24760    24760           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.84% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.29% <ø> (ø) 18561 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bffdbb...6b8f3b6. Read the comment docs.

@patrickjahns

patrickjahns commented Aug 13, 2018

Copy link
Copy Markdown
Contributor

There was the idea to have nightly litmus tests here:
https://github.com/owncloud/litmus-testing

Question:
Do we need to run litmus on every PR - or do we move it also to a nightly approach?

@DeepDiver1975

DeepDiver1975 commented Aug 13, 2018

Copy link
Copy Markdown
Member Author

There was the idea to have nightly litmus tests here:
https://github.com/owncloud/litmus-testing

I know - we can adapt the scenarios over there as well.

Question:
Do we need to run litmus on every PR - or do we move it also to a nightly approach?

Both.

@DeepDiver1975 DeepDiver1975 force-pushed the feature/run-litmus-in-shared-folder branch 7 times, most recently from 9b01b17 to 30cf2ff Compare August 13, 2018 14:17
@DeepDiver1975 DeepDiver1975 changed the title Add litmus test on mounted storage Add litmus test on mounted storage and shared folder Aug 13, 2018
patrickjahns
patrickjahns reviewed Aug 14, 2018
View reviewed changes
Comment thread .drone.yml Outdated
pull: true
commands:
- echo "Create local mount ...."
- mkdir -p /drone/work/local_storage || { echo "Unable to create work folder" >&2; exit 1; }

@patrickjahns patrickjahns Aug 14, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|| ... not required - any fail in the pipe will stop the execution of the next line

Comment thread .drone.yml Outdated
- echo 'Sharing a folder ..'
- OC_PASS=123456 php occ user:add --password-from-env user1
- chown www-data /drone/src -R
- chown www-data /drone/work -R

@patrickjahns patrickjahns Aug 14, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate - seems like you are trying to fix it for local runs as well as remote runs.
If you want to chown the workspace - please use the drone environment variable DRONE_WORKSPACE

@DeepDiver1975 DeepDiver1975 Aug 14, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drone/work/local_storage is created above and needs to be accessible by apache.

there fore the chown

no idea if there are better places ...

patrickjahns
patrickjahns reviewed Aug 14, 2018
View reviewed changes
Comment thread .drone.yml Outdated
- chown www-data /drone/src -R
- chown www-data /drone/work -R
- curl -u user1:123456 -X MKCOL 'http://server/remote.php/webdav/new_folder'
- curl -u user1:123456 "http://server/ocs/v2.php/apps/files_sharing/api/v1/shares" --data 'path=/new_folder&shareType=0&permissions=15&name=new_folder&shareWith=admin'

@patrickjahns patrickjahns Aug 14, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

silence the output

% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0

only show // exit errors

@DeepDiver1975 DeepDiver1975 force-pushed the feature/run-litmus-in-shared-folder branch from 30cf2ff to 6b8f3b6 Compare August 14, 2018 13:21
@DeepDiver1975

DeepDiver1975 commented Aug 14, 2018

Copy link
Copy Markdown
Member Author

@patrickjahns comments addressed ...

@DeepDiver1975 DeepDiver1975 mentioned this pull request Aug 16, 2018
Merged
patrickjahns
patrickjahns approved these changes Aug 16, 2018
View reviewed changes

@patrickjahns patrickjahns left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@patrickjahns patrickjahns merged commit a92877b into master Aug 16, 2018
@patrickjahns patrickjahns deleted the feature/run-litmus-in-shared-folder branch August 16, 2018 13:28
@patrickjahns patrickjahns mentioned this pull request Aug 28, 2018
Closed
@phil-davis

phil-davis commented Aug 28, 2018

Copy link
Copy Markdown
Contributor

Backport stable10 #32362

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@patrickjahns patrickjahns patrickjahns approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@DeepDiver1975 DeepDiver1975

Labels

3 - To Review

Projects

None yet

Milestone

development

Development

Successfully merging this pull request may close these issues.

3 participants

@DeepDiver1975 @patrickjahns @phil-davis