use official docker container for federaated servers by patrickjahns · Pull Request #32413 · owncloud/core

patrickjahns · 2018-08-22T10:50:02Z

Description

Use official docker container in federated tests

Related Issue

Motivation and Context

Fix CI

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

Open tasks:

individual-it · 2018-08-22T10:54:54Z

    pull: true
    environment:
      - TEST_SERVER_URL=http://server
+      - TEST_SERVER_FED_URL=http://federated"


that will make run.sh to try to set various settings on the fed. server, in test cases where it was not started it fails.
that was the reason to use echo "export TEST_SERVER_FED_URL=http://federated" > /drone/saved-settings.sh

we can work with using an environment parameter that is empty - that would avoid the necessity to share on file system level

individual-it · 2018-08-22T10:55:34Z

-    when:
-      matrix:
-        USE_FEDERATED_SERVER: true
+#  install-fed-server:


why not deleting those lines?

Was quickly prototyping - will be deleted when review-ready

patrickjahns · 2018-08-22T15:45:25Z

Issue I am facing now is, that the testing repository would either needed to be moved in a subdirectory to pull the latest changes - or we misuse a github release tag ( 'latest' ) - and re-release the app always on that tag

individual-it · 2018-08-23T05:22:18Z

I would prefer to misuse the tag

codecov · 2018-08-23T07:49:29Z

Codecov Report

Merging #32413 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #32413   +/-   ##
=========================================
  Coverage     64.83%   64.83%           
  Complexity    18319    18319           
=========================================
  Files          1198     1198           
  Lines         69559    69559           
  Branches       1282     1282           
=========================================
  Hits          45100    45100           
  Misses        24086    24086           
  Partials        373      373

Flag	Coverage Δ	Complexity Δ
#javascript	`53.08% <ø> (ø)`	`0 <ø> (ø)`	⬇️
#phpunit	`66.19% <ø> (ø)`	`18319 <ø> (ø)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7a09c4...00c5ac5. Read the comment docs.

patrickjahns · 2018-08-28T10:27:19Z

@ownclouders rebase

ownclouders · 2018-08-28T10:27:21Z

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

ownclouders · 2018-08-28T10:28:25Z

Automated rebase failed! Please rebase your pull request manually via the command line.

Reason:

Command: git rebase base/master

Exit Code: 128

Cause:

error: Failed to merge in the changes.

patrickjahns · 2018-08-30T12:09:41Z

Parts of this PR are superseded by #32505 - but once the Guzzle part is finished, we can move with docker containers as federated servers

patrickjahns · 2018-08-31T09:10:59Z

Rebased to fetch latest changes from core/master - afaik we do not require the guzzle part with ssl certificate anylonger

PVince81 · 2019-02-08T15:20:20Z

@phil-davis please evaluate if we should continue this and reschedule

patrickjahns · 2019-02-14T11:24:27Z

Went over the current ideas and have the following remarks:

DIND is not necessary to start the owncloud container when we don't need to add/edit/mount files directly in the container

federated:
    image: owncloud/server:latest
    pull: true
    detach: true
    environment:
      - OWNCLOUD_APPS_INSTALL=https://github.com/owncloud/testing/releases/download/latest/testing.tar.gz
      - OWNCLOUD_APPS_ENABLE=testing
    when:
      matrix:
        TEST_FEDERATION: true

Now here is the caveat - what type of onwcloud remote instance do we want to test with federation? Following topics need some more thought:

should the federated server have redis ( file locking ) or not?
should we have more than one database system on the federated system ?

Regarding the issue with ssl:
When you continue to use dind - you could mount a custom apache config and also ssl certificates inside the docker containers and start it with ssl

individual-it · 2019-02-14T11:31:47Z

blocked by #34483

individual-it · 2019-02-15T08:59:20Z

seems pretty complicated to me, closing this in favour of the discussion here #34500
We can reopen this PR or reuse the code if needed

patrickjahns added the 2 - Developing label Aug 22, 2018

patrickjahns self-assigned this Aug 22, 2018

patrickjahns requested review from individual-it and phil-davis August 22, 2018 10:50

individual-it requested changes Aug 22, 2018

View reviewed changes

This was referenced Aug 22, 2018

[stable10] install testing app for federation server in CI tests #32411

Merged

install testing app for federation server in CI tests #32410

Merged

patrickjahns force-pushed the master_user_federated_docker branch from ec76af8 to bfd637c Compare August 23, 2018 07:48

patrickjahns force-pushed the master_user_federated_docker branch 5 times, most recently from 84a6ea2 to f0aa89b Compare August 23, 2018 13:55

patrickjahns force-pushed the master_user_federated_docker branch 3 times, most recently from be02985 to f25b730 Compare August 29, 2018 11:37

patrickjahns force-pushed the master_user_federated_docker branch from f25b730 to 72f27e9 Compare August 31, 2018 09:10

patrickjahns force-pushed the master_user_federated_docker branch from 72f27e9 to a649ec0 Compare August 31, 2018 09:23

patrickjahns mentioned this pull request Aug 31, 2018

Helper for fetching ssl certificates owncloud/testing#10

Open

patrickjahns force-pushed the master_user_federated_docker branch 2 times, most recently from 3b77344 to 8f1e8b9 Compare August 31, 2018 19:54

PVince81 assigned phil-davis Feb 8, 2019

PVince81 unassigned patrickjahns Feb 8, 2019

PVince81 added this to the backlog milestone Feb 8, 2019

individual-it assigned individual-it and unassigned phil-davis Feb 12, 2019

patrickjahns and others added 3 commits February 13, 2019 15:37

use official docker container for federaated servers

187ca26

try a workaround to start federated server with just port 80 exposed

882cbb1

fix conflicts

863047f

individual-it force-pushed the master_user_federated_docker branch from 8f1e8b9 to 863047f Compare February 13, 2019 09:52

individual-it added 8 commits February 13, 2019 15:45

delete one wait-for-federated-server

a237d3b

fix naming

98dbcf3

strip down matrix

50c042e

try without waiting

653b318

use correct port number

680e827

use docker host

f15a6db

current oC docker uses port 8080

b98f9eb

no SSL

00c5ac5

individual-it closed this Feb 15, 2019

individual-it deleted the master_user_federated_docker branch February 15, 2019 08:59

lock Bot locked as resolved and limited conversation to collaborators Feb 15, 2020

Uh oh!

Conversation

patrickjahns commented Aug 22, 2018

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Open tasks:

Uh oh!

individual-it Aug 22, 2018

Choose a reason for hiding this comment

Uh oh!

patrickjahns Aug 22, 2018

Choose a reason for hiding this comment

Uh oh!

individual-it Aug 22, 2018

Choose a reason for hiding this comment

Uh oh!

patrickjahns Aug 22, 2018

Choose a reason for hiding this comment

Uh oh!

patrickjahns commented Aug 22, 2018

Uh oh!

individual-it commented Aug 23, 2018

Uh oh!

codecov Bot commented Aug 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

patrickjahns commented Aug 28, 2018

Uh oh!

ownclouders commented Aug 28, 2018

Uh oh!

ownclouders commented Aug 28, 2018

Uh oh!

patrickjahns commented Aug 30, 2018

Uh oh!

patrickjahns commented Aug 31, 2018

Uh oh!

PVince81 commented Feb 8, 2019

Uh oh!

patrickjahns commented Feb 14, 2019

Uh oh!

individual-it commented Feb 14, 2019

Uh oh!

individual-it commented Feb 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Aug 23, 2018 •

edited

Loading