Skip to content

[stable10] use guzzle globally through a helper#32528

Merged
phil-davis merged 1 commit into
stable10from
stable10-guzzleHelper
Aug 31, 2018
Merged

[stable10] use guzzle globally through a helper#32528
phil-davis merged 1 commit into
stable10from
stable10-guzzleHelper

Conversation

@individual-it

Copy link
Copy Markdown
Member

backport of #32505

@codecov

codecov Bot commented Aug 31, 2018

Copy link
Copy Markdown

Codecov Report

Merging #32528 into stable10 will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #32528      +/-   ##
==============================================
+ Coverage       62.88%   62.88%   +<.01%     
  Complexity      18779    18779              
==============================================
  Files            1227     1227              
  Lines           73651    73651              
  Branches         1279     1279              
==============================================
+ Hits            46316    46317       +1     
+ Misses          26955    26954       -1     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.11% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.95% <ø> (ø) 18779 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/Wrapper/Encryption.php 68.05% <0%> (+0.24%) 156% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12006c...d0f8d5e. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Aug 31, 2018

Copy link
Copy Markdown

Codecov Report

Merging #32528 into stable10 will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #32528      +/-   ##
==============================================
+ Coverage       62.88%   62.88%   +<.01%     
  Complexity      18779    18779              
==============================================
  Files            1227     1227              
  Lines           73651    73651              
  Branches         1279     1279              
==============================================
+ Hits            46316    46317       +1     
+ Misses          26955    26954       -1     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.11% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.95% <ø> (ø) 18779 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/Wrapper/Encryption.php 68.05% <0%> (+0.24%) 156% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12006c...d0f8d5e. Read the comment docs.

@phil-davis phil-davis merged commit bcd4e03 into stable10 Aug 31, 2018
@phil-davis phil-davis deleted the stable10-guzzleHelper branch August 31, 2018 04:58
@PVince81 PVince81 modified the milestones: development, QA Sep 5, 2018
@lock lock Bot locked as resolved and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants