acceptance tests - stop uploading when receiving an error#32559
Merged
Conversation
phil-davis
approved these changes
Sep 4, 2018
phil-davis
left a comment
phil-davis
left a comment
Contributor
There was a problem hiding this comment.
The last if is not essential, but good to leave it there in case someone adds more code in future between it and the final return.
Member
Author
|
backport in #32561 |
Codecov Report
@@ Coverage Diff @@
## master #32559 +/- ##
=========================================
Coverage 64.09% 64.09%
Complexity 18654 18654
=========================================
Files 1177 1177
Lines 70232 70232
Branches 1270 1270
=========================================
Hits 45018 45018
Misses 24844 24844
Partials 370 370
Continue to review full report at Codecov.
|
5 tasks
1 task
This was referenced Nov 29, 2018
This was referenced Jan 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
stop uploading with there is an error
when uploading chunks and receiving an error on one chunk, the upload helper would still doing the other steps of the upload
Related Issue
Motivation and Context
Before #32505 there was an exception thrown on errors. We don't do that any-more, because the higher layers might just expect the error code. But now we need to return the error code when it happens and not doing other requests afterwards.
How Has This Been Tested?
run failing tests of firewall
Types of changes
Checklist:
Open tasks: