Log exception when background job class not found by tomneedham · Pull Request #32623 · owncloud/core

tomneedham · 2018-09-06T15:14:27Z

Description

otherwise this goes unnoticed - when apps remove background jobs like market / ldap.

Related Issue

xxx

Motivation and Context

Unknown cron failures

How Has This Been Tested?

Not yet. @cdamken

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

Open tasks:

Backport (if applicable set "backport-request" label and remove when the backport was done)

codecov · 2018-09-06T15:23:52Z

Codecov Report

Merging #32623 into master will increase coverage by 0.35%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #32623      +/-   ##
============================================
+ Coverage     64.81%   65.17%   +0.35%     
+ Complexity    18378    18352      -26     
============================================
  Files          1199     1200       +1     
  Lines         69583    69701     +118     
  Branches       1282     1283       +1     
============================================
+ Hits          45099    45425     +326     
+ Misses        24111    23902     -209     
- Partials        373      374       +1

Flag	Coverage Δ	Complexity Δ
#javascript	`53.1% <ø> (+0.01%)`	`0 <ø> (ø)`	⬇️
#phpunit	`66.56% <100%> (+0.39%)`	`18352 <1> (-26)`	⬇️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/legacy/app.php	`63.8% <ø> (-0.75%)`	`163 <0> (-17)`
lib/private/Server.php	`86.56% <100%> (+0.25%)`	`253 <0> (ø)`	⬇️
lib/private/BackgroundJob/JobList.php	`80.26% <100%> (+6.26%)`	`33 <1> (ø)`	⬇️
lib/private/Setup.php	`26.6% <0%> (-1%)`	`52% <0%> (ø)`
lib/private/Installer.php	`48.18% <0%> (-0.95%)`	`83% <0%> (-4%)`
core/Controller/LostController.php	`88.48% <0%> (-0.24%)`	`33% <0%> (ø)`
lib/private/Updater.php	`12.41% <0%> (-0.18%)`	`51% <0%> (+2%)`
lib/private/legacy/api.php	`40.98% <0%> (-0.17%)`	`85% <0%> (ø)`
...ppFramework/Middleware/Security/CORSMiddleware.php	`100% <0%> (ø)`	`13% <0%> (+1%)`	⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fe1e27...334bae3. Read the comment docs.

tomneedham · 2018-09-06T15:25:36Z

 		foreach ($jobs as $job) {
 			$queue->add($job);
 		}
+		// TODO remove jobs that no longer exist in this app version


We appear to have no way to cleanup job that are removed during an app update

PVince81

👍 makes sense

this also means potential future log pollution as @cdamken found out that some apps aren't removing their jobs when disabled

PVince81 · 2018-10-09T14:05:15Z

@ownclouders rebase

ownclouders · 2018-10-09T14:05:17Z

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

ownclouders · 2018-10-09T14:08:08Z

Automated rebase with GitMate.io was successful! 🎉

PVince81 · 2019-02-12T15:16:36Z

@ownclouders rebase

ownclouders · 2019-02-12T15:16:38Z

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

ownclouders · 2019-02-12T15:18:11Z

Automated rebase with GitMate.io was successful! 🎉

PVince81 · 2019-02-18T18:17:36Z

uh what...

1) Test\BackgroundJob\JobListTest::testUnknownJobLogsException
Doctrine\DBAL\Exception\NotNullConstraintViolationException: An exception occurred while executing 'INSERT INTO "oc_jobs" ("class") VALUES('wrong job title')':

ORA-01400: cannot insert NULL into ("AUTOTEST"."oc_jobs"."argument")

/drone/src/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractOracleDriver.php:49
/drone/src/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:169
/drone/src/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:145
/drone/src/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1063
/drone/src/lib/private/DB/Connection.php:207
/drone/src/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:203
/drone/src/lib/private/DB/QueryBuilder/QueryBuilder.php:141
/drone/src/tests/lib/BackgroundJob/JobListTest.php:259
/drone/src/tests/lib/BackgroundJob/JobListTest.php:263

Caused by
Doctrine\DBAL\Driver\OCI8\OCI8Exception: ORA-01400: cannot insert NULL into ("AUTOTEST"."oc_jobs"."argument")

/drone/src/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Driver/OCI8/OCI8Exception.php:16
/drone/src/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php:372
/drone/src/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Driver/OCI8/OCI8Connection.php:136
/drone/src/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1060
/drone/src/lib/private/DB/Connection.php:207
/drone/src/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:203
/drone/src/lib/private/DB/QueryBuilder/QueryBuilder.php:141
/drone/src/tests/lib/BackgroundJob/JobListTest.php:259
/drone/src/tests/lib/BackgroundJob/JobListTest.php:263

phil-davis · 2019-03-09T06:42:34Z

Backport stable10 #34723

tomneedham added the 3 - To Review label Sep 6, 2018

tomneedham added this to the development milestone Sep 6, 2018

tomneedham self-assigned this Sep 6, 2018

tomneedham force-pushed the log-job-not-found branch from c369248 to 6edf69f Compare September 6, 2018 15:23

tomneedham commented Sep 6, 2018

View reviewed changes

PVince81 approved these changes Oct 9, 2018

View reviewed changes

PVince81 added the backport-request label Oct 9, 2018

ownclouders force-pushed the log-job-not-found branch from 6edf69f to 8795602 Compare October 9, 2018 14:07

ownclouders mentioned this pull request Oct 16, 2018

Also log previous exception when given #33204

Closed

2 tasks

PVince81 assigned PVince81 and unassigned tomneedham Feb 12, 2019

Log when a job is created with a missing path name

b9b1d17

ownclouders force-pushed the log-job-not-found branch from 8795602 to b9b1d17 Compare February 12, 2019 15:18

PVince81 added 4 - To release and removed 3 - To Review labels Feb 18, 2019

Fix code styles

115d7a1

Add extra joblist arg in test for Oracle

334bae3

PVince81 merged commit 0783f10 into master Feb 18, 2019

delete-merged-branch Bot deleted the log-job-not-found branch February 18, 2019 21:23

phil-davis mentioned this pull request Mar 9, 2019

[stable10] Log exception when background job class not found #34723

Merged

phil-davis removed the backport-request label Mar 9, 2019

phil-davis mentioned this pull request Mar 18, 2019

Add background:execute occ command for running cron jobs manually #31617

Merged

9 tasks

VicDeo mentioned this pull request Jun 21, 2019

Backgroundjob error messages: SyncJob does not exist #35589

Open

lock Bot locked as resolved and limited conversation to collaborators Mar 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Log exception when background job class not found#32623

Log exception when background job class not found#32623
PVince81 merged 3 commits into
masterfrom
log-job-not-found

tomneedham commented Sep 6, 2018

Uh oh!

codecov Bot commented Sep 6, 2018 •

edited

Loading

Uh oh!

tomneedham Sep 6, 2018

Uh oh!

PVince81 left a comment

Uh oh!

PVince81 commented Oct 9, 2018

Uh oh!

ownclouders commented Oct 9, 2018

Uh oh!

ownclouders commented Oct 9, 2018

Uh oh!

PVince81 commented Feb 12, 2019

Uh oh!

ownclouders commented Feb 12, 2019

Uh oh!

ownclouders commented Feb 12, 2019

Uh oh!

PVince81 commented Feb 18, 2019

Uh oh!

phil-davis commented Mar 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

tomneedham commented Sep 6, 2018

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Open tasks:

Uh oh!

codecov Bot commented Sep 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tomneedham Sep 6, 2018

Choose a reason for hiding this comment

Uh oh!

PVince81 left a comment

Choose a reason for hiding this comment

Uh oh!

PVince81 commented Oct 9, 2018

Uh oh!

ownclouders commented Oct 9, 2018

Uh oh!

ownclouders commented Oct 9, 2018

Uh oh!

PVince81 commented Feb 12, 2019

Uh oh!

ownclouders commented Feb 12, 2019

Uh oh!

ownclouders commented Feb 12, 2019

Uh oh!

PVince81 commented Feb 18, 2019

Uh oh!

phil-davis commented Mar 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Sep 6, 2018 •

edited

Loading