API acceptance tests for WebDAV search - #32816
Merged
Merged
Conversation
individual-it
changed the title
phil-davis
reviewed
Sep 24, 2018
| * @return string or false if file could not be found | ||
| */ | ||
| public function findFileFromPropfindResponse($user, $fileNameToSearch) { | ||
| //if we using that step the second time in a scenario e.g. 'But ... should not' |
Contributor
There was a problem hiding this comment.
if we are using the step the second time...
phil-davis
reviewed
Sep 24, 2018
| public function findFileFromPropfindResponse($user, $fileNameToSearch) { | ||
| //if we using that step the second time in a scenario e.g. 'But ... should not' | ||
| //then don't parse the result again, because the result in a ResponseInterface | ||
| //and can only be read once |
phil-davis
approved these changes
Sep 24, 2018
phil-davis
left a comment
phil-davis
left a comment
Contributor
There was a problem hiding this comment.
Looks good.
That ['value'][1]['value'][0]['value'] stuff is ugly, but what to do about that?
individual-it
force-pushed
the
apiTestSeach
branch
from
September 24, 2018 12:17
55b3253 to
c856c08
Compare
Codecov Report
@@ Coverage Diff @@
## master #32816 +/- ##
=========================================
Coverage 64.12% 64.12%
Complexity 18684 18684
=========================================
Files 1177 1177
Lines 70309 70309
Branches 1270 1270
=========================================
Hits 45089 45089
Misses 24850 24850
Partials 370 370
Continue to review full report at Codecov.
|
Member
Author
|
backport in #32818 |
individual-it
force-pushed
the
apiTestSeach
branch
from
September 24, 2018 14:58
c856c08 to
8839817
Compare
individual-it
force-pushed
the
apiTestSeach
branch
from
September 24, 2018 16:31
8839817 to
cc14596
Compare
Contributor
|
stupid thing, no codecov has come so we cannot merge. |
Contributor
|
Now it failed That scenario seems to fail sometimes. I guess there is some timing problem with the public link dialog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
API tests to test webdav search see #31873
Related Issue
owncloud/search_elastic#26
How Has This Been Tested?
run the tests locally
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: