[stable10] Unskip tests for issue 29599#33402
Merged
Merged
Conversation
phil-davis
requested review from
DeepDiver1975,
individual-it and
paurakhsharma
Contributor
|
we'll need another kind of update of Sabre to make this work. last I heard @DeepDiver1975 said we need to backport the fixing patch from the Sabre major to the current minor or something along these lines |
Contributor
Author
|
@PVince81 the test scenarios pass |
individual-it
approved these changes
Nov 5, 2018
Member
|
CI is green, so as much as the tests are concerned the problem is solved, till someone invents a new tests that shows the problem again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #31724