Sharing folder sync stable45

[schiessle]

This fixes the problem we had while syncing the Shared folder (issue #260) for stable45. For master we will wait until the new file cache is in place.

• The main problem was that the etags where stored for each virtual "Shared-folder-path" but not for the real physical path. To detect changes from every user with access to the file I now store only the real path in the properties table.
• Since I need to get the origin file source of a shared folder/file I created a new class OC_Files_Sharing_Util which provides public access to the necessary code originally implemented in OC_Filestorage_Shared. For now I just copied the necessary functions over to the new class to avoid unwanted side effects.
• Since it is quite hard and expensive to find all users which have access to a particular file I decided to always modify the etag for the Shared folder. This means that for every check the sync client will look in the root sync dir and the root of the shared folder for changes.

@dragotin and @danimo please also have a look at it and test it with the desktop client.

[ste80pa]

I found those bugs after replacing files changed in this discussion:

on local folder controlled by owncloud client 1.1.1 in Shared folder:

1] if you create a folder , changes are not propagate correctly (but thi works using web interface)
2] if you move a directory , changes are not propagate correctly

on web client (ownlcoud 4.5.1)

1] doesnt`work properly move action for files an directory inside a shared folder

[schiessle]

Thank you very much for testing!

1] if you create a folder , changes are not propagate correctly (but thi works using web interface)

I can't reproduce this. Can you give me a concrete example which I can try to reproduce? Just to be sure, you create a directory in a shared directory (not in the root Shared-directory) where you have the right to create new directories/files, right?

2] if you move a directory , changes are not propagate correctly

I just tried it.This happens with both, the sync client and the web interface, right? This is really bad but not a sync client only problem. I will try to come up with a patch for this problem. The patch we are discussing here deals with problems directly related to the sync client and not with more general sharing bugs.

Do we have a bug report for this issue? If not, please open one. Thanks!

[ste80pa]

For what concerns the point 1] i have this scenario :
** There is shared folder owned by admin user.
** This folder is shared with 2 users,that are in the same group of "admin" and having all edit permission granted.
** This shared folder is named "BlaBlaBla".

Now when i create a new directory under the shared folder "BlaBlaBla" i can`t see this folder on server side.
This directory in not created.

For what concerns the point 2] the answer is Yes , it does not work either in web and client side :D

[dragotin]

Tested basic sync functionality which worked so far. +1 to merge. Thx Björn :)

[karlitschek]

awesome guys!!! :-)

[ste80pa]

I have just tested new patch on stable45 branch 💃

now everything is working well :D

very very good job boys !!!!