Skip to content

Revert "merge teststeps"#33812

Merged
phil-davis merged 1 commit into
masterfrom
revert-33680-mergeTests
Dec 7, 2018
Merged

Revert "merge teststeps"#33812
phil-davis merged 1 commit into
masterfrom
revert-33680-mergeTests

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

Reverts #33680

Scenario: Upload a file called "0" using new chunking is a bug in core 10.0.10

So we do not want it to end up in the smokeTest scenario outline examples, because then it may get run against an "old" 10.010 system, and of course it will fail.

We cannot tag individual rows of an example table. So it can't be "fixed" in place.

After reverting this, we need to sort out how to tag this scenario appropriately, e.g. skipOnOcV10.0.10

@codecov

codecov Bot commented Dec 7, 2018

Copy link
Copy Markdown

Codecov Report

Merging #33812 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33812   +/-   ##
=========================================
  Coverage     64.35%   64.35%           
  Complexity    18309    18309           
=========================================
  Files          1195     1195           
  Lines         69255    69255           
  Branches       1276     1276           
=========================================
  Hits          44566    44566           
  Misses        24317    24317           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.98% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.66% <ø> (+0.33%) 18309 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/QueryBuilder/QueryBuilder.php 91.34% <0%> (ø) 68% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaWriter.php 94.79% <0%> (ø) 34% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaManager.php 91.22% <0%> (ø) 17% <0%> (ø) ⬇️
lib/private/Files/Cache/Cache.php 98.1% <0%> (ø) 105% <0%> (ø) ⬇️
lib/private/AllConfig.php 93.15% <0%> (ø) 43% <0%> (ø) ⬇️
lib/private/Repair/RepairInvalidShares.php 97.26% <0%> (ø) 17% <0%> (ø) ⬇️
lib/private/Repair/RepairMismatchFileCachePath.php 96.88% <0%> (ø) 51% <0%> (ø) ⬇️
lib/private/DB/ConnectionFactory.php 89.85% <0%> (ø) 20% <0%> (ø) ⬇️
lib/private/DB/Adapter.php 88.88% <0%> (ø) 25% <0%> (ø) ⬇️
lib/private/DB/OracleConnection.php 66.66% <0%> (ø) 12% <0%> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcbb9de...3f0e123. Read the comment docs.

2 similar comments
@codecov

codecov Bot commented Dec 7, 2018

Copy link
Copy Markdown

Codecov Report

Merging #33812 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33812   +/-   ##
=========================================
  Coverage     64.35%   64.35%           
  Complexity    18309    18309           
=========================================
  Files          1195     1195           
  Lines         69255    69255           
  Branches       1276     1276           
=========================================
  Hits          44566    44566           
  Misses        24317    24317           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.98% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.66% <ø> (+0.33%) 18309 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/QueryBuilder/QueryBuilder.php 91.34% <0%> (ø) 68% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaWriter.php 94.79% <0%> (ø) 34% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaManager.php 91.22% <0%> (ø) 17% <0%> (ø) ⬇️
lib/private/Files/Cache/Cache.php 98.1% <0%> (ø) 105% <0%> (ø) ⬇️
lib/private/AllConfig.php 93.15% <0%> (ø) 43% <0%> (ø) ⬇️
lib/private/Repair/RepairInvalidShares.php 97.26% <0%> (ø) 17% <0%> (ø) ⬇️
lib/private/Repair/RepairMismatchFileCachePath.php 96.88% <0%> (ø) 51% <0%> (ø) ⬇️
lib/private/DB/ConnectionFactory.php 89.85% <0%> (ø) 20% <0%> (ø) ⬇️
lib/private/DB/Adapter.php 88.88% <0%> (ø) 25% <0%> (ø) ⬇️
lib/private/DB/OracleConnection.php 66.66% <0%> (ø) 12% <0%> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcbb9de...3f0e123. Read the comment docs.

@codecov

codecov Bot commented Dec 7, 2018

Copy link
Copy Markdown

Codecov Report

Merging #33812 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33812   +/-   ##
=========================================
  Coverage     64.35%   64.35%           
  Complexity    18309    18309           
=========================================
  Files          1195     1195           
  Lines         69255    69255           
  Branches       1276     1276           
=========================================
  Hits          44566    44566           
  Misses        24317    24317           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.98% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.66% <ø> (+0.33%) 18309 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/QueryBuilder/QueryBuilder.php 91.34% <0%> (ø) 68% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaWriter.php 94.79% <0%> (ø) 34% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaManager.php 91.22% <0%> (ø) 17% <0%> (ø) ⬇️
lib/private/Files/Cache/Cache.php 98.1% <0%> (ø) 105% <0%> (ø) ⬇️
lib/private/AllConfig.php 93.15% <0%> (ø) 43% <0%> (ø) ⬇️
lib/private/Repair/RepairInvalidShares.php 97.26% <0%> (ø) 17% <0%> (ø) ⬇️
lib/private/Repair/RepairMismatchFileCachePath.php 96.88% <0%> (ø) 51% <0%> (ø) ⬇️
lib/private/DB/ConnectionFactory.php 89.85% <0%> (ø) 20% <0%> (ø) ⬇️
lib/private/DB/Adapter.php 88.88% <0%> (ø) 25% <0%> (ø) ⬇️
lib/private/DB/OracleConnection.php 66.66% <0%> (ø) 12% <0%> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcbb9de...3f0e123. Read the comment docs.

@phil-davis

Copy link
Copy Markdown
Contributor Author

stable10 revert is in PR #33813

@phil-davis

phil-davis commented Dec 7, 2018

Copy link
Copy Markdown
Contributor Author

Note: this 0 file name scenario was originally unskipped in PR #31724 because the bug was fixed by the underlying release of sabre/dav sabre-io/dav@3.2.2...3.2.3
Applied by dependabot in PR #33276

@phil-davis phil-davis merged commit 8532325 into master Dec 7, 2018
@delete-merged-branch delete-merged-branch Bot deleted the revert-33680-mergeTests branch December 7, 2018 14:48
@lock lock Bot locked as resolved and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants