Fix cancel upload and hide 'uploading' message for files_drop shared folders

[VicDeo]

Description

Fix not working cancel upload and hide 'Uploading' message after the upload is done.

Related Issue

• Fixes "File Drop" Public Link Cancelling is Buggy #33177

Motivation and Context

How Has This Been Tested?

#33177 (comment)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[codecov]

Codecov Report

Merging #33937 into master will decrease coverage by 0.02%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master   #33937      +/-   ##
============================================
- Coverage     64.77%   64.75%   -0.03%     
- Complexity    18330    18336       +6     
============================================
  Files          1198     1198              
  Lines         69374    69400      +26     
  Branches       1276     1276              
============================================
  Hits          44938    44938              
- Misses        24064    24090      +26     
  Partials        372      372

Flag	Coverage Δ	Complexity Δ
#javascript	52.97% <33.33%> (-0.01%)	0 <0> (ø)
#phpunit	66.11% <ø> (-0.03%)	18336 <ø> (+6)

Impacted Files	Coverage Δ	Complexity Δ
apps/files_sharing/js/PublicUploadView.js	73.8% <33.33%> (-3.12%)	0 <0> (ø)
apps/files_external/lib/config.php	10.71% <0%> (-5.68%)	19% <0%> (+6%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00bd3c0...cc1e600. Read the comment docs.

[codecov]

Codecov Report

Merging #33937 into master will decrease coverage by <.01%.
The diff coverage is 14.28%.

@@             Coverage Diff              @@
##             master   #33937      +/-   ##
============================================
- Coverage     64.77%   64.76%   -0.01%     
  Complexity    18340    18340              
============================================
  Files          1198     1198              
  Lines         69418    69425       +7     
  Branches       1276     1276              
============================================
+ Hits          44964    44965       +1     
- Misses        24085    24091       +6     
  Partials        369      369

Flag	Coverage Δ	Complexity Δ
#javascript	53.05% <14.28%> (-0.04%)	0 <0> (ø)
#phpunit	66.12% <ø> (ø)	18340 <ø> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
apps/files_sharing/js/PublicUploadView.js	67.39% <14.28%> (-9.54%)	0 <0> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91b662d...14424b3. Read the comment docs.

[PVince81]

@VicDeo would you manage some unit tests ? and/or UI tests ?

[phil-davis]

@VicDeo this suffered from the recent problem merged to master this afternoon.
Rebase and CI will feel better.

[VicDeo]

@PVince81 I see no opportunity for the unit tests here. acceptance tests are possible with a lot of pain.
Aching in progress...

[PVince81]

if this was never covered before it's an opportunity to bootstrap the tests... good luck

[VicDeo]

@PVince81 yes, files_drop page is not covered with acceptance tests at all.
Basic file upload scenario has been added.
Our tests consider file to be uploaded as soon as the progress bar disappears.

[PVince81]

👍 fair enough

tests to be bootstrapped separately

[PVince81]

@VicDeo please backport for 10.1.1

[VicDeo]

Stable10: #34097