Skip to content

Install testing app when running webUIWebdavLocks#33956

Merged
phil-davis merged 1 commit into
masterfrom
fix-webUIWebdavLocks-INSTALL_TESTING-APP
Dec 20, 2018
Merged

Install testing app when running webUIWebdavLocks#33956
phil-davis merged 1 commit into
masterfrom
fix-webUIWebdavLocks-INSTALL_TESTING-APP

Conversation

@phil-davis

@phil-davis phil-davis commented Dec 20, 2018

Copy link
Copy Markdown
Contributor

Description

A recent PR that added the test suite webUIWebdavLocks missed a recent refactoring of the steps in .drone.yml that install the testing app - 5bc6f03
So the PR managed to get merged without a conflict being reported, but the new matrix entry in .drone.yml was missing:

INSTALL_TESTING-APP: true

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81

Copy link
Copy Markdown
Contributor

please backport

@phil-davis

Copy link
Copy Markdown
Contributor Author

Backport for stable10 has been cherry-picked into #33951 by @PVince81

@codecov

codecov Bot commented Dec 20, 2018

Copy link
Copy Markdown

Codecov Report

Merging #33956 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33956   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    18336    18336           
=========================================
  Files          1198     1198           
  Lines         69403    69403           
  Branches       1276     1276           
=========================================
  Hits          44950    44950           
  Misses        24084    24084           
  Partials        369      369
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.11% <ø> (ø) 18336 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30671a0...7fea5d5. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Dec 20, 2018

Copy link
Copy Markdown

Codecov Report

Merging #33956 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33956   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    18336    18336           
=========================================
  Files          1198     1198           
  Lines         69403    69403           
  Branches       1276     1276           
=========================================
  Hits          44950    44950           
  Misses        24084    24084           
  Partials        369      369
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.11% <ø> (ø) 18336 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30671a0...7fea5d5. Read the comment docs.

@phil-davis phil-davis merged commit ad225a4 into master Dec 20, 2018
@delete-merged-branch delete-merged-branch Bot deleted the fix-webUIWebdavLocks-INSTALL_TESTING-APP branch December 20, 2018 17:32
@lock lock Bot locked as resolved and limited conversation to collaborators Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants