Skip to content

Check the HTTP status of federated share test uploads#34577

Merged
phil-davis merged 1 commit into
masterfrom
federated-http-status-checks
Feb 22, 2019
Merged

Check the HTTP status of federated share test uploads#34577
phil-davis merged 1 commit into
masterfrom
federated-http-status-checks

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

Description

Add Then the HTTP status code should be test steps to the apiFederation acceptance test scenarios.

Related Issue

Motivation and Context

When federation acceptance test scenarios fail (e.g. the expected etag did not change, or expected file contents did not change) then it is not obvious where the problem might be. It could be a problem with the upload, or with the interaction between the remote and local servers.

It is nicer to test the HTTP status of the upload first. Then we will quickly see when the server itself reports some problem.

e.g. PR #34568 is in development and failing some of these apiFederation acceptance test scenarios. In order to debug the problem, seeing the HTTP status will be helpful.

How Has This Been Tested?

Local acceptance test run of the apiFederation suite.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis

Copy link
Copy Markdown
Contributor Author

Backport stable10 #34578

@codecov

codecov Bot commented Feb 22, 2019

Copy link
Copy Markdown

Codecov Report

Merging #34577 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34577   +/-   ##
=========================================
  Coverage     65.16%   65.16%           
  Complexity    18364    18364           
=========================================
  Files          1200     1200           
  Lines         69684    69684           
  Branches       1283     1283           
=========================================
  Hits          45407    45407           
  Misses        23903    23903           
  Partials        374      374
Flag Coverage Δ Complexity Δ
#javascript 53.1% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.55% <ø> (ø) 18364 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 217e803...24afbaf. Read the comment docs.

@phil-davis phil-davis merged commit 574d8bb into master Feb 22, 2019
@delete-merged-branch delete-merged-branch Bot deleted the federated-http-status-checks branch February 22, 2019 07:44
@lock lock Bot locked as resolved and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants