Check the HTTP status of federated share test uploads#34577
Merged
Conversation
individual-it
approved these changes
Feb 22, 2019
Contributor
Author
|
Backport |
11 tasks
Codecov Report
@@ Coverage Diff @@
## master #34577 +/- ##
=========================================
Coverage 65.16% 65.16%
Complexity 18364 18364
=========================================
Files 1200 1200
Lines 69684 69684
Branches 1283 1283
=========================================
Hits 45407 45407
Misses 23903 23903
Partials 374 374
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
Then the HTTP status code should betest steps to theapiFederationacceptance test scenarios.Related Issue
Motivation and Context
When federation acceptance test scenarios fail (e.g. the expected etag did not change, or expected file contents did not change) then it is not obvious where the problem might be. It could be a problem with the upload, or with the interaction between the remote and local servers.
It is nicer to test the HTTP status of the upload first. Then we will quickly see when the server itself reports some problem.
e.g. PR #34568 is in development and failing some of these
apiFederationacceptance test scenarios. In order to debug the problem, seeing the HTTP status will be helpful.How Has This Been Tested?
Local acceptance test run of the
apiFederationsuite.Types of changes
Checklist:
Open tasks: