Throw exception in getOCSResponseStatusCode if responseXml has no OCS status#34582
Merged
Conversation
individual-it
approved these changes
Feb 22, 2019
11 tasks
Codecov Report
@@ Coverage Diff @@
## master #34582 +/- ##
=========================================
Coverage 65.16% 65.16%
Complexity 18364 18364
=========================================
Files 1200 1200
Lines 69684 69684
Branches 1283 1283
=========================================
Hits 45407 45407
Misses 23903 23903
Partials 374 374
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #34582 +/- ##
=========================================
Coverage 65.16% 65.16%
Complexity 18364 18364
=========================================
Files 1200 1200
Lines 69684 69684
Branches 1283 1283
=========================================
Hits 45407 45407
Misses 23903 23903
Partials 374 374
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Throw an exception in getOCSResponseStatusCode if responseXml has no OCS status
Related Issue
During development PR #34568 had a problem where an API call returned a good HTTP status, but did not fill in the OCS status. That cause the acceptance test code to fall over in a "not very nice" way.
How Has This Been Tested?
Local runs against development software with issues.
Types of changes
Checklist:
Open tasks: