Skip to content

test ocs endpoints with invalid credentials#34643

Merged
individual-it merged 5 commits into
masterfrom
testOcsWrongPassword
Feb 28, 2019
Merged

test ocs endpoints with invalid credentials#34643
individual-it merged 5 commits into
masterfrom
testOcsWrongPassword

Conversation

@individual-it

@individual-it individual-it commented Feb 28, 2019

Copy link
Copy Markdown
Member

Description

test for correct response when using the endpoints with invalid credentials

Related Issue

part of #34566

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)
  • adjust LDAP tests as a new suite was added

@phil-davis phil-davis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine. Just one place where I think the scenario description is a cut-paste of another one.

Comment thread tests/acceptance/features/apiAuth/ocsPOSTAuth.feature Outdated
@codecov

codecov Bot commented Feb 28, 2019

Copy link
Copy Markdown

Codecov Report

Merging #34643 into master will decrease coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34643      +/-   ##
============================================
- Coverage     65.23%   64.61%   -0.62%     
  Complexity    18438    18438              
============================================
  Files          1203     1203              
  Lines         69825    69792      -33     
  Branches       1280     1280              
============================================
- Hits          45548    45096     -452     
- Misses        23905    24324     +419     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.94% <ø> (-0.69%) 18438 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/AdapterOCI8.php 0% <0%> (-86.67%) 4% <0%> (ø)
...ivate/Files/ObjectStore/HomeObjectStoreStorage.php 0% <0%> (-86.67%) 8% <0%> (ø)
...Builder/ExpressionBuilder/OCIExpressionBuilder.php 0% <0%> (-85.19%) 18% <0%> (ø)
lib/private/DB/OracleMigrator.php 0% <0%> (-80.71%) 29% <0%> (ø)
lib/private/DB/OracleConnection.php 0% <0%> (-66.67%) 12% <0%> (ø)
lib/private/Files/Storage/Wrapper/Availability.php 10.38% <0%> (-38.97%) 80% <0%> (ø)
lib/private/Files/ObjectStore/NoopScanner.php 68.75% <0%> (-18.75%) 6% <0%> (ø)
lib/private/Share/Share.php 27.04% <0%> (-16.33%) 70% <0%> (ø)
...b/private/Files/ObjectStore/ObjectStoreStorage.php 70.97% <0%> (-14.34%) 102% <0%> (ø)
lib/private/Preview/MP3.php 45.16% <0%> (-12.91%) 13% <0%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb9857...13625fe. Read the comment docs.

@codecov

codecov Bot commented Feb 28, 2019

Copy link
Copy Markdown

Codecov Report

Merging #34643 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34643   +/-   ##
=========================================
  Coverage     65.23%   65.23%           
  Complexity    18438    18438           
=========================================
  Files          1203     1203           
  Lines         69825    69825           
  Branches       1280     1280           
=========================================
  Hits          45548    45548           
  Misses        23905    23905           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.63% <ø> (ø) 18438 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb9857...13625fe. Read the comment docs.

@individual-it

Copy link
Copy Markdown
Member Author

backport in #34645

@individual-it
individual-it merged commit c9a4d98 into master Feb 28, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the testOcsWrongPassword branch February 28, 2019 11:18
@lock lock Bot locked as resolved and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants