Skip to content

[stable10] Add per default the apps-external directory in config.php during installation#34656

Merged
PVince81 merged 1 commit into
stable10from
stable10-30889-03e6987
Mar 4, 2019
Merged

[stable10] Add per default the apps-external directory in config.php during installation#34656
PVince81 merged 1 commit into
stable10from
stable10-30889-03e6987

Conversation

@mmattel

@mmattel mmattel commented Mar 1, 2019

Copy link
Copy Markdown
Contributor

Description

Backport of #30889

Related Issue

Motivation and Context

See the issue description regarding the benefits.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

…s2_on_initial_install

Add per default the apps-external directory in config.php during installation
@phil-davis

Copy link
Copy Markdown
Contributor

https://drone.owncloud.com/owncloud/core/15692/169

./tests/drone/test-phpunit.sh: line 71: 29 Segmentation fault (core dumped)

I will restart drone

@codecov

codecov Bot commented Mar 2, 2019

Copy link
Copy Markdown

Codecov Report

Merging #34656 into stable10 will decrease coverage by 2.61%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34656      +/-   ##
==============================================
- Coverage       66.61%      64%   -2.62%     
+ Complexity      19409    19247     -162     
==============================================
  Files            1162     1276     +114     
  Lines           64738    75801   +11063     
  Branches            0     1291    +1291     
==============================================
+ Hits            43127    48515    +5388     
- Misses          21611    26907    +5296     
- Partials            0      379     +379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (?) 0 <ø> (?)
#phpunit 65.15% <0%> (-1.47%) 19247 <0> (-162)
Impacted Files Coverage Δ Complexity Δ
lib/private/Setup.php 25.66% <0%> (-0.95%) 53 <0> (+1)
lib/private/Files/Cache/HomePropagator.php 88.88% <0%> (-11.12%) 3% <0%> (ø)
apps/files/lib/Command/Scan.php 71.84% <0%> (-9.39%) 62% <0%> (ø)
lib/private/Files/Storage/DAV.php 81.09% <0%> (-7.78%) 0% <0%> (-161%)
lib/private/DB/AdapterOCI8.php 86.66% <0%> (-6.2%) 4% <0%> (ø)
lib/private/DB/OracleConnection.php 66.66% <0%> (-1.91%) 12% <0%> (ø)
...Builder/ExpressionBuilder/OCIExpressionBuilder.php 85.18% <0%> (-1.61%) 18% <0%> (ø)
apps/files_external/lib/Command/Backends.php 0% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_external/lib/Lib/Backend/DAV.php 0% <0%> (ø) 0% <0%> (?)
... and 157 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87240fd...0431e73. Read the comment docs.

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants