Skip to content

[master] Don't expose hashed password in ocs api#34726

Merged
phil-davis merged 1 commit into
masterfrom
dont_expose_hashed_password_oc
Mar 9, 2019
Merged

[master] Don't expose hashed password in ocs api#34726
phil-davis merged 1 commit into
masterfrom
dont_expose_hashed_password_oc

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

Forward port of PR #34691 from stable10 to master

@codecov

codecov Bot commented Mar 9, 2019

Copy link
Copy Markdown

Codecov Report

Merging #34726 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34726   +/-   ##
=========================================
  Coverage      65.3%    65.3%           
  Complexity    18478    18478           
=========================================
  Files          1209     1209           
  Lines         69964    69964           
  Branches       1280     1280           
=========================================
  Hits          45688    45688           
  Misses        23904    23904           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.71% <100%> (ø) 18478 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...es_sharing/lib/Controller/Share20OcsController.php 85.34% <100%> (ø) 193 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77a815d...810be77. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Mar 9, 2019

Copy link
Copy Markdown

Codecov Report

Merging #34726 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34726   +/-   ##
=========================================
  Coverage      65.3%    65.3%           
  Complexity    18478    18478           
=========================================
  Files          1209     1209           
  Lines         69964    69964           
  Branches       1280     1280           
=========================================
  Hits          45688    45688           
  Misses        23904    23904           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.71% <100%> (ø) 18478 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...es_sharing/lib/Controller/Share20OcsController.php 85.34% <100%> (ø) 193 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77a815d...810be77. Read the comment docs.

@IljaN IljaN left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@IljaN IljaN self-requested a review March 9, 2019 10:48
@phil-davis phil-davis merged commit f430ede into master Mar 9, 2019
@delete-merged-branch delete-merged-branch Bot deleted the dont_expose_hashed_password_oc branch March 9, 2019 11:50
@lock lock Bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants