Skip to content

[stable10] Add drone step to print the server logs in case of failure#34792

Merged
individual-it merged 3 commits into
stable10from
stable10-print-log-drone
Mar 18, 2019
Merged

[stable10] Add drone step to print the server logs in case of failure#34792
individual-it merged 3 commits into
stable10from
stable10-print-log-drone

Conversation

@phil-davis

@phil-davis phil-davis commented Mar 18, 2019

Copy link
Copy Markdown
Contributor
  1. Backport Increase version to 10.1 prealpha #28043 commit 203bb4b

which somehow has never found its way back to stable10

  1. Run owncloud-coding-standard on PHP 7.3 just to be the same as in master (we are about to do PHP 7.3 support anyway) We have phan running on PHP 7.0, 7.1, 7.2 which provides us an effective lint check already for those PHP versions.

  2. Fixup a comment indent that got different between stable10 and master

@codecov

codecov Bot commented Mar 18, 2019

Copy link
Copy Markdown

Codecov Report

Merging #34792 into stable10 will decrease coverage by 19.16%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             stable10   #34792       +/-   ##
===============================================
- Coverage        64.2%   45.04%   -19.17%     
===============================================
  Files            1278      116     -1162     
  Lines           76256    11476    -64780     
  Branches         1291     1291               
===============================================
- Hits            48958     5169    -43789     
+ Misses          26919     5928    -20991     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 30.71% <ø> (-34.66%) 0 <ø> (-19885)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 59.45% <0%> (-21.64%) 0% <0%> (ø)
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
... and 1154 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 487394d...b9710f7. Read the comment docs.

@codecov

codecov Bot commented Mar 18, 2019

Copy link
Copy Markdown

Codecov Report

Merging #34792 into stable10 will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34792      +/-   ##
==============================================
+ Coverage        64.2%    64.2%   +<.01%     
  Complexity      19885    19885              
==============================================
  Files            1278     1278              
  Lines           76256    76256              
  Branches         1291     1291              
==============================================
+ Hits            48958    48959       +1     
+ Misses          26919    26918       -1     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.36% <ø> (ø) 19885 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 86.65% <0%> (+0.11%) 253% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 487394d...1f46e5f. Read the comment docs.

@individual-it individual-it merged commit 5437bc6 into stable10 Mar 18, 2019
@delete-merged-branch delete-merged-branch Bot deleted the stable10-print-log-drone branch March 18, 2019 13:02
@lock lock Bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants