Fix for File Drop view#34803
Merged
Merged
Conversation
Delete unused value
Contributor
|
@ChrisEdS did you check that IE11 also works fine ? from what I remember we used to have troubles with IE related to this kind of pages. it was back in the IE8 days though, might not be an issue nowadays |
Author
|
@PVince81 Works fine on IE, too. |
Author
|
@PVince81 Do we bring this to the 10.2.0 release? |
lordelix
approved these changes
Apr 29, 2019
Contributor
|
not critical, so no. 10.3 then |
Contributor
|
@ChrisEdS please backport to stable10 |
Contributor
|
Backport |
Author
|
Thank you @phil-davis, I completely missed this task. |
13 tasks
Contributor
Author
Hello @haribhandari07, thank you for reporting this. May I ask you which resolution you are using? |
Contributor
|
@ChrisEdS the screen resolution of my phone is 720 x 1280 and the screen size is 5.5 inches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
The File Drop view had a scroll bar. This is absolutely unnecessary. This pull request provides enough distance from the info text to the lower edge.
Motivation and Context
The File Drop view had a scroll bar. This is absolutely unnecessary.
How Has This Been Tested?
Tested in Firefox and Chrome
Screenshots:
Mobile view before:
Mobile view after:
Browser view before:
Browser view after:
Types of changes
Checklist:
Open tasks: