Skip to content

[stable10] Improve error handling for incoming shares poll command#34993

Merged
PVince81 merged 1 commit into
stable10from
stable10-implement-34981
Apr 9, 2019
Merged

[stable10] Improve error handling for incoming shares poll command#34993
PVince81 merged 1 commit into
stable10from
stable10-implement-34981

Conversation

@VicDeo

@VicDeo VicDeo commented Apr 9, 2019

Copy link
Copy Markdown
Contributor

Backport of #34992

Description

Output more details when the share is skipped due to exception

Related Issue

How Has This Been Tested?

  1. Created a federated share,
  2. Accepted it
  3. Changed token on the owner side to be invalid.
  4. executed occ incoming-shares:poll on the recipient side

Screenshots (if appropriate):

> php occ incoming-shares:poll
Skipping external share with id "1225" from remote "http://localhost/~deo/stable10". Reason: "Sabre\HTTP\ClientHttpException: Unauthorized"

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added

@VicDeo VicDeo added this to the development milestone Apr 9, 2019
@VicDeo VicDeo self-assigned this Apr 9, 2019
@VicDeo VicDeo requested a review from PVince81 April 9, 2019 11:02

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 443bf44 into stable10 Apr 9, 2019
@PVince81 PVince81 deleted the stable10-implement-34981 branch April 9, 2019 17:21
@lock lock Bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants