Respect 'writable' appdir flag on update

[VicDeo]

Description

Related Issue

• Fixes App manager not respecting writable flag when folder writable on disk #35031

Motivation and Context

Fix App is updated inside the directory that is marked as not writable.

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[codecov]

Codecov Report

Merging #35072 into master will increase coverage by 0.01%.
The diff coverage is 91.66%.

@@             Coverage Diff              @@
##             master   #35072      +/-   ##
============================================
+ Coverage     65.37%   65.38%   +0.01%     
- Complexity    18626    18631       +5     
============================================
  Files          1215     1215              
  Lines         70532    70540       +8     
  Branches       1295     1295              
============================================
+ Hits          46112    46125      +13     
+ Misses        24046    24041       -5     
  Partials        374      374

Flag	Coverage Δ	Complexity Δ
#javascript	52.85% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.83% <91.66%> (+0.01%)	18631 <0> (+5)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/legacy/app.php	66.27% <100%> (+1.37%)	166 <0> (+5)	⬆️
lib/private/Installer.php	48.18% <66.66%> (ø)	83 <0> (ø)	⬇️
lib/private/AllConfig.php	95.89% <0%> (+1.36%)	43% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b884aac...dd436d4. Read the comment docs.

[PVince81]

@VicDeo please fix CI failure due to coding standard

[VicDeo]

@PVince81 updated

[PVince81]

👍

[VicDeo]

@PVince81 the fix was unreliable, some (not all) phpunit jobs were failing so I moved
\OC::$server->getAppManager()->clearAppsCache();
towards the beginning of OC_App::updateApp additionally

[PVince81]

👍 ok, looks fine

[PVince81]

@VicDeo please backport to release-10.2.0

[VicDeo]

release-10.2.0: #35097

[phil-davis]

Backport happened to release-10.2.0 and the release branch has been merged into stable10 so backport is done.