Skip to content

Extend SharingApi test context to test uppercase to lowercase conversion#35156

Closed
micbar wants to merge 1 commit into
masterfrom
tests/uppercase-SharingApi
Closed

Extend SharingApi test context to test uppercase to lowercase conversion#35156
micbar wants to merge 1 commit into
masterfrom
tests/uppercase-SharingApi

Conversation

@micbar

@micbar micbar commented May 6, 2019

Copy link
Copy Markdown
Contributor

Description

Extend Acceptance Test Suite

Related Issue

Motivation and Context

We need to test the stability of the SharingAPI even if we feed it with uppercase/lowercase differences to the correctn UID

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov

codecov Bot commented May 6, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35156 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35156   +/-   ##
=========================================
  Coverage     65.48%   65.48%           
  Complexity    18636    18636           
=========================================
  Files          1217     1217           
  Lines         70536    70536           
  Branches       1296     1296           
=========================================
  Hits          46194    46194           
  Misses        23965    23965           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.5% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.87% <ø> (ø) 18636 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc5f317...c3b664e. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented May 6, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35156 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35156   +/-   ##
=========================================
  Coverage     65.48%   65.48%           
  Complexity    18636    18636           
=========================================
  Files          1217     1217           
  Lines         70536    70536           
  Branches       1296     1296           
=========================================
  Hits          46194    46194           
  Misses        23965    23965           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.5% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.87% <ø> (ø) 18636 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc5f317...c3b664e. Read the comment docs.

@micbar
micbar requested a review from phil-davis May 6, 2019 12:38
@individual-it

Copy link
Copy Markdown
Member

in owncloud/guests#325 you don't use that new step and I don't understand why creating a new function and not using userHasSharedFileWithUserUsingTheSharingApi() ?

@micbar

micbar commented May 7, 2019

Copy link
Copy Markdown
Contributor Author

@individual-it

  1. I do not use it in the guest pr because the new method is not in daily-stable-10-qa.
    I intend to use it.

  2. The other method throws an error if you use it with an uppercase UserID and the shareAPI returns the UserID converted to lowercase. We need a method which accepts the conversion of the UserID.

@individual-it

Copy link
Copy Markdown
Member

so we could use \strtolower every time. meaning put it into userHasSharedFileWithUserUsingTheSharingApi() as it will not make a difference for the other tests and we can have one function less

@individual-it

Copy link
Copy Markdown
Member

closing in favour of #35342

@individual-it
individual-it deleted the tests/uppercase-SharingApi branch June 10, 2019 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants