Catch internal server error from remote on decline#35178
Conversation
ca5dce3 to
c1fbd89
Compare
Codecov Report
@@ Coverage Diff @@
## master #35178 +/- ##
============================================
- Coverage 65.54% 65.53% -0.01%
- Complexity 18647 18651 +4
============================================
Files 1218 1218
Lines 70546 70549 +3
Branches 1288 1288
============================================
Hits 46236 46236
- Misses 23933 23936 +3
Partials 377 377
Continue to review full report at Codecov.
|
c1fbd89 to
b2b0ea8
Compare
b2b0ea8 to
95cff43
Compare
| $event->getRemoteId(), | ||
| $event->getShareToken() | ||
| ); | ||
| } catch (\Exception $e) { |
There was a problem hiding this comment.
Any chance to refine this exception into GuzzleHttpException or something similar that might be being thrown? It's unlikely that a BlaBlaBlaException with code 500 reaches this point, but we'll have problems detecting this scenario with this code. It's the typical thing that will take a long time to detect.
There was a problem hiding this comment.
changed to be \GuzzleHttp\Exception\ServerException
95cff43 to
1c2c7fb
Compare
1c2c7fb to
65a3e14
Compare
65a3e14 to
ea3f39c
Compare
|
@VicDeo please backport. |
|
Stable10: #35321 |
Description
Handle 500 exception on declining a share
Motivation and Context
Before 10.2 response for declining non-existing shares was 500
#34786 changes HTTP status from 500 to 410
But declining any non-existing share for OC lower than 10.2 still causing unhandled exception.
How Has This Been Tested?
Types of changes
Checklist:
Open tasks: