Skip to content

Fix acceptance test method for finding dialogs with content and title#35246

Closed
dpakach wants to merge 1 commit into
masterfrom
fix-find-dialog-method
Closed

Fix acceptance test method for finding dialogs with content and title#35246
dpakach wants to merge 1 commit into
masterfrom
fix-find-dialog-method

Conversation

@dpakach

@dpakach dpakach commented May 16, 2019

Copy link
Copy Markdown
Contributor

Description

Modify the method WebUIGeneralContext::dialogsShouldBeDisplayedOnTheWebUI to work with either only title or only content as well.

Related Issue

Motivation and Context

this method expected both title and content in the tablenode. But sometimes ownCloud gives dynamically generated content. In that case we may want to check only the title of the dialog but which is not possible with current method.

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Comment thread tests/acceptance/features/bootstrap/WebUIGeneralContext.php Outdated
@codecov

codecov Bot commented May 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35246 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35246   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2873da5...b660af6. Read the comment docs.

@codecov

codecov Bot commented May 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35246 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35246   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6db604e...72bd971. Read the comment docs.

@individual-it individual-it requested a review from sharidas May 17, 2019 06:47
@individual-it

Copy link
Copy Markdown
Member
WebUIGeneralContext::dialogsShouldBeDisplayedOnTheWebUI()
      | title        | content                                                                                             |
      | Remote share | Do you want to add the remote share /simple-folder from user1@%remote_server_without_scheme%?       |
      | Remote share | Do you want to add the remote share /simple-empty-folder from user2@%remote_server_without_scheme%? |
      | Remote share | Do you want to add the remote share /lorem.txt from user3@%remote_server_without_scheme%?           |
      Could not find dialog with title :'Remote share' content :'Do you want to add the remote share /simple-folder from user1@%remote_server_without_scheme%?' 
      Failed asserting that false is true.

in tests/acceptance/features/webUISharingExternal/federationSharing.feature:25

@dpakach dpakach requested a review from paurakhsharma May 23, 2019 06:23
@dpakach dpakach force-pushed the fix-find-dialog-method branch from b660af6 to 72bd971 Compare May 23, 2019 06:56
@dpakach dpakach requested a review from individual-it May 23, 2019 08:15
@dpakach

dpakach commented May 23, 2019

Copy link
Copy Markdown
Contributor Author

This changes are not needed now and add more complexity. So closing for now.

@dpakach dpakach closed this May 23, 2019
@dpakach dpakach removed the request for review from sharidas May 23, 2019 10:53
@dpakach dpakach deleted the fix-find-dialog-method branch November 24, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants