Fix acceptance test method for finding dialogs with content and title#35246
Closed
dpakach wants to merge 1 commit into
Closed
Fix acceptance test method for finding dialogs with content and title#35246dpakach wants to merge 1 commit into
dpakach wants to merge 1 commit into
Conversation
f427348 to
b660af6
Compare
Codecov Report
@@ Coverage Diff @@
## master #35246 +/- ##
=========================================
Coverage 65.54% 65.54%
Complexity 18647 18647
=========================================
Files 1218 1218
Lines 70546 70546
Branches 1288 1288
=========================================
Hits 46236 46236
Misses 23933 23933
Partials 377 377
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35246 +/- ##
=========================================
Coverage 65.54% 65.54%
Complexity 18647 18647
=========================================
Files 1218 1218
Lines 70546 70546
Branches 1288 1288
=========================================
Hits 46236 46236
Misses 23933 23933
Partials 377 377
Continue to review full report at Codecov.
|
individual-it
approved these changes
May 17, 2019
Member
in |
b660af6 to
72bd971
Compare
Contributor
Author
|
This changes are not needed now and add more complexity. So closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modify the method
WebUIGeneralContext::dialogsShouldBeDisplayedOnTheWebUIto work with either onlytitleor onlycontentas well.Related Issue
Motivation and Context
this method expected both
titleandcontentin the tablenode. But sometimes ownCloud gives dynamically generated content. In that case we may want to check only the title of the dialog but which is not possible with current method.How Has This Been Tested?
🤖
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: