quote inline code when checking response#35249
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #35249 +/- ##
=========================================
Coverage 65.54% 65.54%
Complexity 18647 18647
=========================================
Files 1218 1218
Lines 70546 70546
Branches 1288 1288
=========================================
Hits 46236 46236
Misses 23933 23933
Partials 377 377
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #35249 +/- ##
=========================================
Coverage 65.54% 65.54%
Complexity 18647 18647
=========================================
Files 1218 1218
Lines 70546 70546
Branches 1288 1288
=========================================
Hits 46236 46236
Misses 23933 23933
Partials 377 377
Continue to review full report at Codecov.
|
skshetry
approved these changes
May 16, 2019
Member
Author
|
backport in #35250 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
if the replacement value of an inline code contains a
/we need to quote isMotivation and Context
in tests like
apiWebdavLocks/publicLinkLockdiscovery.feature:18we substitute%base_path%and if that contains/likeowncloud-10.2.0/rc3we get errors likeWarning: preg_match(): Unknown modifier 'r' in /home/artur/www/owncloud-core/lib/composer/phpunit/phpunit/src/Framework/Constraint/RegularExpression.php line 47How Has This Been Tested?
make sure tests run that did not run before
Types of changes
Checklist:
Open tasks: