Skip to content

quote inline code when checking response#35249

Merged
individual-it merged 1 commit into
masterfrom
quoteInlineQuote
May 17, 2019
Merged

quote inline code when checking response#35249
individual-it merged 1 commit into
masterfrom
quoteInlineQuote

Conversation

@individual-it

@individual-it individual-it commented May 16, 2019

Copy link
Copy Markdown
Member

Description

if the replacement value of an inline code contains a / we need to quote is

Motivation and Context

in tests like apiWebdavLocks/publicLinkLockdiscovery.feature:18 we substitute %base_path% and if that contains / like owncloud-10.2.0/rc3 we get errors like Warning: preg_match(): Unknown modifier 'r' in /home/artur/www/owncloud-core/lib/composer/phpunit/phpunit/src/Framework/Constraint/RegularExpression.php line 47

How Has This Been Tested?

make sure tests run that did not run before

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov

codecov Bot commented May 16, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35249 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35249   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd65cb...3cb9499. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented May 16, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35249 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35249   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd65cb...3cb9499. Read the comment docs.

@individual-it
individual-it requested a review from phil-davis May 16, 2019 12:38
@individual-it
individual-it merged commit 07fbc9c into master May 17, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the quoteInlineQuote branch May 17, 2019 03:11
@individual-it

Copy link
Copy Markdown
Member Author

backport in #35250

@lock lock Bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants