Skip to content

Add cli tests for background queue status and delete#35254

Merged
paurakhsharma merged 1 commit into
masterfrom
cli-Test-background-queue-status
May 21, 2019
Merged

Add cli tests for background queue status and delete#35254
paurakhsharma merged 1 commit into
masterfrom
cli-Test-background-queue-status

Conversation

@paurakhsharma

@paurakhsharma paurakhsharma commented May 17, 2019

Copy link
Copy Markdown
Contributor

Description

Add cli acceptance tests for background:queue:status and background:queue: delete

Had to create a new background job OC\Command\CommandJob by
deleting a file so that the background:queue:delete can delete this newly created
background job maintaining the test isolation.

Related Issue

#35229

Motivation and Context

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@paurakhsharma paurakhsharma requested review from dpakach and skshetry May 17, 2019 07:12
@paurakhsharma paurakhsharma self-assigned this May 17, 2019
dpakach
dpakach reviewed May 17, 2019
View reviewed changes
Comment thread tests/acceptance/features/cliBackground/backgroundQueue.feature
@codecov

codecov Bot commented May 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35254 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35254   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2873da5...d1c2891. Read the comment docs.

@codecov

codecov Bot commented May 17, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #35254 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35254      +/-   ##
============================================
+ Coverage     65.54%   65.54%   +<.01%     
  Complexity    18647    18647              
============================================
  Files          1218     1218              
  Lines         70546    70546              
  Branches       1288     1288              
============================================
+ Hits          46236    46237       +1     
+ Misses        23933    23932       -1     
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_trashbin/lib/Expiration.php 98.27% <0%> (+1.72%) 29% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0dc3cd...c6f4fed. Read the comment docs.

dpakach
dpakach reviewed May 17, 2019
View reviewed changes
Comment thread tests/acceptance/features/cliBackground/backgroundQueue.feature
skshetry
skshetry reviewed May 17, 2019
View reviewed changes
Comment thread tests/acceptance/features/cliBackground/backgroundQueue.feature
skshetry
skshetry reviewed May 17, 2019
View reviewed changes

@skshetry skshetry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

individual-it
individual-it requested changes May 17, 2019
View reviewed changes

@individual-it individual-it left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we make sure the job is back for the next test after deleting it?

Comment thread tests/acceptance/features/bootstrap/OccContext.php Outdated
@paurakhsharma

paurakhsharma commented May 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

how do we make sure the job is back for the next test after deleting it?

The job is created every time the scenario runs.
The job OC\Command\CommandJob is created when a user deletes their file.

@paurakhsharma paurakhsharma force-pushed the cli-Test-background-queue-status branch from d1c2891 to e7ad1bc Compare May 17, 2019 09:25
@paurakhsharma

paurakhsharma commented May 17, 2019

Copy link
Copy Markdown
Contributor Author

@PVince81 @patrickjahns Can you please merge this. Codecov is crossing it's limits 😄

@skshetry skshetry mentioned this pull request May 17, 2019
Merged
11 tasks
@individual-it

individual-it commented May 20, 2019

Copy link
Copy Markdown
Member

@ownclouders rebase

skshetry
skshetry previously requested changes May 20, 2019
View reviewed changes

@skshetry skshetry left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to be rebased, and the function theCommandOutputTableShouldContainTheFollowingText should be removed from here, as it is already in the #35257.

Dismiss this review when it's done (verify by looking at the diff, no theCommandOutputTableShouldContainTheFollowingText should be there).

@paurakhsharma paurakhsharma force-pushed the cli-Test-background-queue-status branch from e7ad1bc to a250138 Compare May 20, 2019 10:30
@paurakhsharma paurakhsharma dismissed skshetry’s stale review May 20, 2019 10:31

I have removed the conflicting method.

@paurakhsharma paurakhsharma force-pushed the cli-Test-background-queue-status branch from a250138 to c6f4fed Compare May 20, 2019 10:42
@individual-it

individual-it commented May 21, 2019

Copy link
Copy Markdown
Member

restarted drone build

@paurakhsharma paurakhsharma merged commit 30a974c into master May 21, 2019
@delete-merged-branch delete-merged-branch Bot deleted the cli-Test-background-queue-status branch May 21, 2019 05:10
@individual-it

individual-it commented May 21, 2019

Copy link
Copy Markdown
Member

fixes #35229

@paurakhsharma paurakhsharma mentioned this pull request May 21, 2019
Merged
@lock lock Bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@individual-it individual-it individual-it approved these changes
@phil-davis phil-davis Awaiting requested review from phil-davis
+2 more reviewers
@dpakach dpakach dpakach left review comments
@skshetry skshetry skshetry left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@paurakhsharma paurakhsharma

Labels

3 - To Review dev:acceptance-tests QA:team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@paurakhsharma @individual-it @phil-davis @skshetry @dpakach @micbar