Skip to content

restore acceptance tests to the correct server#35258

Merged
individual-it merged 1 commit into
masterfrom
restoreSettingsToCorrectServer
May 17, 2019
Merged

restore acceptance tests to the correct server#35258
individual-it merged 1 commit into
masterfrom
restoreSettingsToCorrectServer

Conversation

@individual-it

@individual-it individual-it commented May 17, 2019

Copy link
Copy Markdown
Member

Description

follow up PR #35119
when restoring settings we need to make sure they are restored to the correct server

Motivation and Context

CI in encryption was broken with strange errors
log contains these messages: Could not decrypt the private key from user \"admin\"\" during login. Assume password change on the user back-end. Error message: Bad Signature
after a long time of digging I found something very confusing:

  • when the server starts and sets up encryption it takes the correct secret from the config
  • after a while it switches to the secret of the federated server.
    see: https://drone.owncloud.com/owncloud/encryption/688/12
    all is well till line 72, then suddenly the secret changes, and so all hashes etc. are wrong
    you can see the secrets in "configure-federation-server" and in "install-app"

How Has This Been Tested?

🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@dpakach dpakach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@individual-it

Copy link
Copy Markdown
Member Author

backport in #35259

@codecov

codecov Bot commented May 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35258 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35258      +/-   ##
============================================
+ Coverage     65.53%   65.54%   +<.01%     
  Complexity    18647    18647              
============================================
  Files          1218     1218              
  Lines         70545    70546       +1     
  Branches       1288     1288              
============================================
+ Hits          46234    46236       +2     
+ Misses        23934    23933       -1     
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 86.69% <0%> (+0.11%) 253% <0%> (ø) ⬇️
...eratedfilesharing/lib/Controller/OcmController.php 66.26% <0%> (+0.2%) 30% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d77f5b7...d93e09c. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented May 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35258 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35258      +/-   ##
============================================
+ Coverage     65.53%   65.54%   +<.01%     
  Complexity    18647    18647              
============================================
  Files          1218     1218              
  Lines         70545    70546       +1     
  Branches       1288     1288              
============================================
+ Hits          46234    46236       +2     
+ Misses        23934    23933       -1     
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 86.69% <0%> (+0.11%) 253% <0%> (ø) ⬇️
...eratedfilesharing/lib/Controller/OcmController.php 66.26% <0%> (+0.2%) 30% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d77f5b7...d93e09c. Read the comment docs.

@individual-it
individual-it merged commit 7d3ebdc into master May 17, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the restoreSettingsToCorrectServer branch May 17, 2019 17:20
@lock lock Bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants