restore acceptance tests to the correct server#35258
Merged
Merged
Conversation
dpakach
approved these changes
May 17, 2019
Member
Author
|
backport in #35259 |
Codecov Report
@@ Coverage Diff @@
## master #35258 +/- ##
============================================
+ Coverage 65.53% 65.54% +<.01%
Complexity 18647 18647
============================================
Files 1218 1218
Lines 70545 70546 +1
Branches 1288 1288
============================================
+ Hits 46234 46236 +2
+ Misses 23934 23933 -1
Partials 377 377
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #35258 +/- ##
============================================
+ Coverage 65.53% 65.54% +<.01%
Complexity 18647 18647
============================================
Files 1218 1218
Lines 70545 70546 +1
Branches 1288 1288
============================================
+ Hits 46234 46236 +2
+ Misses 23934 23933 -1
Partials 377 377
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
follow up PR #35119
when restoring settings we need to make sure they are restored to the correct server
Motivation and Context
CI in encryption was broken with strange errors
log contains these messages:
Could not decrypt the private key from user \"admin\"\" during login. Assume password change on the user back-end. Error message: Bad Signatureafter a long time of digging I found something very confusing:
see: https://drone.owncloud.com/owncloud/encryption/688/12
all is well till line 72, then suddenly the secret changes, and so all hashes etc. are wrong
you can see the secrets in "configure-federation-server" and in "install-app"
How Has This Been Tested?
🤖
Types of changes
Checklist:
Open tasks: