Add cli tests for config file values#35269
Merged
Merged
Conversation
dpakach
reviewed
May 20, 2019
dpakach
reviewed
May 20, 2019
paurakhsharma
force-pushed
the
cli-Test-configKey
branch
from
May 20, 2019 11:26
9201414 to
2c144f6
Compare
Codecov Report
@@ Coverage Diff @@
## master #35269 +/- ##
============================================
- Coverage 65.54% 65.53% -0.01%
Complexity 18647 18647
============================================
Files 1218 1218
Lines 70546 70545 -1
Branches 1288 1288
============================================
- Hits 46236 46234 -2
- Misses 23933 23934 +1
Partials 377 377
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35269 +/- ##
=========================================
Coverage 65.54% 65.54%
Complexity 18647 18647
=========================================
Files 1218 1218
Lines 70546 70546
Branches 1288 1288
=========================================
Hits 46236 46236
Misses 23933 23933
Partials 377 377
Continue to review full report at Codecov.
|
paurakhsharma
force-pushed
the
cli-Test-configKey
branch
2 times, most recently
from
May 21, 2019 07:48
6e9e1cc to
42a42d7
Compare
skshetry
reviewed
May 21, 2019
skshetry
reviewed
May 21, 2019
skshetry
reviewed
May 21, 2019
| $system_config = $config_list['system']; | ||
| $configArray = $system_config[$key]; | ||
|
|
||
| foreach ($configArray as $innerConfigArray) { |
Contributor
There was a problem hiding this comment.
Guiding comments please .....
Contributor
Author
There was a problem hiding this comment.
@skshetry Please have a look at the comments.
paurakhsharma
force-pushed
the
cli-Test-configKey
branch
2 times, most recently
from
May 21, 2019 11:22
2c9315d to
3604510
Compare
individual-it
requested changes
May 22, 2019
paurakhsharma
force-pushed
the
cli-Test-configKey
branch
from
May 22, 2019 06:59
3604510 to
e712d32
Compare
individual-it
requested changes
May 22, 2019
| increment the foundCount value | ||
| Note: all the values from the tableNode should be present inside the same | ||
| config array that's why foundCount is used */ | ||
| if ($innerConfigArray[$value['key']] === $value['value']) { |
Member
There was a problem hiding this comment.
we could delete from the table the found keys and then the ones that are not found will be left over, so the error can show which one were not found
Contributor
Author
There was a problem hiding this comment.
Yeah, that seems to be the better way.
paurakhsharma
force-pushed
the
cli-Test-configKey
branch
from
May 23, 2019 06:40
e712d32 to
14067f0
Compare
individual-it
requested changes
May 23, 2019
paurakhsharma
force-pushed
the
cli-Test-configKey
branch
from
May 23, 2019 08:14
14067f0 to
314609a
Compare
individual-it
requested changes
May 23, 2019
paurakhsharma
force-pushed
the
cli-Test-configKey
branch
from
May 23, 2019 08:36
314609a to
20149a7
Compare
individual-it
approved these changes
May 23, 2019
Member
|
@paurakhsharma please backport and mark in #35207 |
Contributor
Author
|
Backport on: #35320 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add cli tests for checking
config.phpdefault values.Related Issue
#31347
Motivation and Context
How Has This Been Tested?
🤖
Screenshots (if appropriate):
Types of changes
Checklist: