Add acceptance test flags in makefile for autocompletion#35271
Conversation
058e957 to
d64f7d9
Compare
Codecov Report
@@ Coverage Diff @@
## master #35271 +/- ##
============================================
+ Coverage 65.53% 66.39% +0.86%
+ Complexity 18648 18647 -1
============================================
Files 1218 1157 -61
Lines 70549 63234 -7315
Branches 1288 0 -1288
============================================
- Hits 46236 41987 -4249
+ Misses 23936 21247 -2689
+ Partials 377 0 -377
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35271 +/- ##
=========================================
Coverage 65.53% 65.53%
Complexity 18648 18648
=========================================
Files 1218 1218
Lines 70549 70549
Branches 1288 1288
=========================================
Hits 46236 46236
Misses 23936 23936
Partials 377 377
Continue to review full report at Codecov.
|
phil-davis
left a comment
There was a problem hiding this comment.
Please mention the shells that you know will work for this.
It will help other people to understand if they have any hope to use it.
d64f7d9 to
907cdbb
Compare
|
@phil-davis, this currently only supports |
|
Works for me with |
|
It broke CI. Maybe it sees |
907cdbb to
44edc6b
Compare
Forgot about the exports. It should now work
|
Backport for |
Description
This PR adds flag to the makefile, so that, if your terminal support this (
zsh, maybefishas well), you'll get autocompletion for makefile env variables. Sadly,bash-completionsdoes not support variable autocompletion.Related Issue
Motivation and Context
Just felt like it would help.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: