Skip to content

Test if robots.txt is accessible or not#35284

Merged
individual-it merged 1 commit into
masterfrom
test-robotstxt-access
May 21, 2019
Merged

Test if robots.txt is accessible or not#35284
individual-it merged 1 commit into
masterfrom
test-robotstxt-access

Conversation

@skshetry

@skshetry skshetry commented May 21, 2019

Copy link
Copy Markdown
Contributor

Description

This adds a test if robots.txt is accessible or not, and the content is same. Tests for #34949

Related Issue

Part of #35207

Motivation and Context

#35207

How Has This Been Tested?

  • locally
  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@paurakhsharma paurakhsharma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me: 👍

@skshetry

Copy link
Copy Markdown
Contributor Author

Backport for stable10 on #35285

@codecov

codecov Bot commented May 21, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35284 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35284   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30a974c...42743ea. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented May 21, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35284 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35284   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30a974c...42743ea. Read the comment docs.

@individual-it individual-it merged commit 8a33127 into master May 21, 2019
@delete-merged-branch delete-merged-branch Bot deleted the test-robotstxt-access branch May 21, 2019 13:17
@lock lock Bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants