Skip to content

[stable10] do not disable encryption app after test run#35288

Merged
individual-it merged 1 commit into
stable10from
fixStable10UnitTests
May 21, 2019
Merged

[stable10] do not disable encryption app after test run#35288
individual-it merged 1 commit into
stable10from
fixStable10UnitTests

Conversation

@individual-it

@individual-it individual-it commented May 21, 2019

Copy link
Copy Markdown
Member

Description

currently stable10 unit tests fail in drone e.g. see https://drone.owncloud.com/owncloud/core/17499/142
git bisect shows that the first broken commit is 7ad78e9 of PR #35000

further investigation showed that deleting that single line fixed the problem at least locally for me. Now lets see if it helps CI

Why didn't it fail in the first place but started at some point later????

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@sharidas sharidas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

PS: Strange that disabling app has caused issue now :(

@individual-it

Copy link
Copy Markdown
Member Author

@sharidas should we port that also to the encryption app?

@individual-it individual-it changed the title do not disable encryption app after test run [stable10] do not disable encryption app after test run May 21, 2019
@individual-it
individual-it force-pushed the fixStable10UnitTests branch from 68733fc to a17da84 Compare May 21, 2019 11:48
@codecov

codecov Bot commented May 21, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35288 into stable10 will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35288      +/-   ##
==============================================
+ Coverage       64.52%   64.54%   +0.02%     
  Complexity      20080    20080              
==============================================
  Files            1289     1289              
  Lines           76947    76923      -24     
  Branches         1299     1299              
==============================================
+ Hits            49650    49651       +1     
+ Misses          26916    26891      -25     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.2% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.74% <ø> (+0.02%) 20080 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/Wrapper/Encryption.php 76.16% <0%> (-0.25%) 156% <0%> (ø)
lib/private/Server.php 86.56% <0%> (ø) 253% <0%> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 98.27% <0%> (+1.72%) 29% <0%> (ø) ⬇️
apps/encryption/appinfo/routes.php 100% <0%> (+100%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a964a1...a17da84. Read the comment docs.

@codecov

codecov Bot commented May 21, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35288 into stable10 will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35288      +/-   ##
==============================================
- Coverage       64.52%   64.27%   -0.25%     
  Complexity      20080    20080              
==============================================
  Files            1289     1289              
  Lines           76947    76923      -24     
  Branches         1299     1299              
==============================================
- Hits            49650    49444     -206     
- Misses          26916    27098     +182     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.2% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.45% <ø> (-0.28%) 20080 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/AdapterOCI8.php 0% <0%> (-86.67%) 4% <0%> (ø)
...Builder/ExpressionBuilder/OCIExpressionBuilder.php 0% <0%> (-85.19%) 18% <0%> (ø)
lib/private/DB/OracleMigrator.php 0% <0%> (-80.71%) 29% <0%> (ø)
lib/private/DB/OracleConnection.php 0% <0%> (-66.67%) 12% <0%> (ø)
lib/private/DB/Adapter.php 82.71% <0%> (-6.18%) 25% <0%> (ø)
lib/private/DB/ConnectionFactory.php 78.94% <0%> (-3.95%) 21% <0%> (ø)
lib/private/Repair/RepairMismatchFileCachePath.php 94.57% <0%> (-3.49%) 51% <0%> (ø)
lib/private/Repair/RepairInvalidShares.php 97.26% <0%> (-2.74%) 17% <0%> (ø)
lib/private/AllConfig.php 92.46% <0%> (-2.06%) 43% <0%> (ø)
lib/private/Files/Cache/Cache.php 95.82% <0%> (-1.8%) 110% <0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a964a1...a17da84. Read the comment docs.

@sharidas

Copy link
Copy Markdown
Contributor

@sharidas should we port that also to the encryption app?

I think it would be better if we port it.

@individual-it
individual-it merged commit 1c084bf into stable10 May 21, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the fixStable10UnitTests branch May 21, 2019 13:43
@individual-it

Copy link
Copy Markdown
Member Author

port to encryption app in owncloud/encryption#127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants