Skip to content

[stable10] Backport of Accessing sharetab directly for a long list of files #35306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sharidas merged 1 commit into from
May 23, 2019
Merged

[stable10] Backport of Accessing sharetab directly for a long list of files #35306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions apps/files/js/filelist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2533,6 +2533,18 @@
}
if (!_.isUndefined(detailTabId)) {
var filename = file[file.length - 1];
//Double check if the area that you are scrolling is beyond the page limit?
var pageSize = this.pageSize();
var index = _.findIndex(this.files, function (obj) {
return obj.name === filename;
});
if (index >= pageSize) {
var numberOfMorePagesToScroll = Math.floor(index / pageSize);
while (numberOfMorePagesToScroll > 0) {
this._nextPage();
numberOfMorePagesToScroll--;
}
}
this.showDetailsView(filename, detailTabId);
}
this.highlightFiles(file, function($tr) {
Expand Down
5 changes: 1 addition & 4 deletions tests/acceptance/features/webUIFiles/browseDirectlyToDetailsTab.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,11 @@ Feature: browse directly to details tab

#merge this tests into previous scenario when bug is fixed
@smokeTest
@issue-35200
Scenario Outline: Browse directly to the sharing details of a file
When the user tries to browse directly to display the "sharing" details of file "<file>" in folder "<folder>"
#Then the thumbnail should be visible in the details panel
Then the "sharing" details panel should be visible
And the share-with field should not be visible in the details panel
And the share-with field should be visible in the details panel
#And the share-with field should be visible in the details panel
Examples:
| file | folder | comment |
Expand All @@ -48,7 +47,6 @@ Feature: browse directly to details tab
| lorem.txt | simple-folder | a file somewhere in between |

#merge this tests into previous scenario when bug is fixed
@issue-35200
@comments-app-required
Scenario Outline: Browse directly to the comments details of a file
When the user tries to browse directly to display the "comments" details of file "<file>" in folder "<folder>"
Expand All @@ -72,7 +70,6 @@ Feature: browse directly to details tab
| lorem.txt | simple-folder | a file somewhere in between |

#merge this tests into previous scenario when bug is fixed
@issue-35200
@files_versions-app-required
Scenario Outline: Browse directly to the versions details of a file
When the user tries to browse directly to display the "versions" details of file "<file>" in folder "<folder>"
Expand Down