api test for sharing with user by entering username in capital letters by haribhandari07 · Pull Request #35309 · owncloud/core

haribhandari07 · 2019-05-23T06:09:47Z

Description

includes api test for creating new shares using sharing api by entering username in capital letters

Related Issue

Part of issue #35354

Motivation and Context

How Has This Been Tested?

CI

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Database schema changes (next release will require increase of minor version instead of patch)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests only (no source changes)

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

Open tasks:

Backport (if applicable set "backport-request" label and remove when the backport was done)

individual-it

please check also if the user did receive the file
there are steps line ... should see following elements

individual-it · 2019-05-23T06:17:09Z

-      | 2               | 200             |
+      | 2               | 200             |
+
+  Scenario: share with user by entering username in capital letters


Suggested change

Scenario: share with user by entering username in capital letters

Scenario: share with user when username contains capital letters

codecov · 2019-05-23T06:44:39Z

Codecov Report

Merging #35309 into master will decrease coverage by 0.6%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #35309      +/-   ##
============================================
- Coverage     65.54%   64.93%   -0.61%     
  Complexity    18647    18647              
============================================
  Files          1218     1218              
  Lines         70546    70512      -34     
  Branches       1288     1288              
============================================
- Hits          46236    45789     -447     
- Misses        23933    24346     +413     
  Partials        377      377

Flag	Coverage Δ	Complexity Δ
#javascript	`53.69% <ø> (ø)`	`0 <ø> (ø)`	⬇️
#phpunit	`66.23% <ø> (-0.68%)`	`18647 <ø> (ø)`

Impacted Files	Coverage Δ	Complexity Δ
lib/private/DB/AdapterOCI8.php	`0% <0%> (-86.67%)`	`4% <0%> (ø)`
...ivate/Files/ObjectStore/HomeObjectStoreStorage.php	`0% <0%> (-86.67%)`	`8% <0%> (ø)`
...Builder/ExpressionBuilder/OCIExpressionBuilder.php	`0% <0%> (-85.19%)`	`18% <0%> (ø)`
lib/private/DB/OracleMigrator.php	`0% <0%> (-80.71%)`	`29% <0%> (ø)`
lib/private/DB/OracleConnection.php	`0% <0%> (-66.67%)`	`12% <0%> (ø)`
lib/private/Files/Storage/Wrapper/Availability.php	`10.38% <0%> (-38.97%)`	`80% <0%> (ø)`
lib/private/Files/ObjectStore/NoopScanner.php	`68.75% <0%> (-18.75%)`	`6% <0%> (ø)`
lib/private/Share/Share.php	`27.04% <0%> (-16.33%)`	`70% <0%> (ø)`
...b/private/Files/ObjectStore/ObjectStoreStorage.php	`70.97% <0%> (-14.34%)`	`102% <0%> (ø)`
lib/private/Preview/MP3.php	`45.16% <0%> (-12.91%)`	`13% <0%> (ø)`
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6db604e...f34b5d8. Read the comment docs.

codecov · 2019-05-23T06:44:45Z

Codecov Report

Merging #35309 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #35309   +/-   ##
=========================================
  Coverage     65.53%   65.53%           
  Complexity    18648    18648           
=========================================
  Files          1218     1218           
  Lines         70549    70549           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23936    23936           
  Partials        377      377

Flag	Coverage Δ	Complexity Δ
#javascript	`53.69% <ø> (ø)`	`0 <ø> (ø)`	⬇️
#phpunit	`66.89% <ø> (ø)`	`18648 <ø> (ø)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 413e3e3...5c15a34. Read the comment docs.

paurakhsharma

Tests look good to me 👍

skshetry · 2019-05-23T08:50:22Z

+  Scenario: share with user when username contains capital letters
+    Given these users have been created:
+      | username |
+      | ocuser0  |


Suggested change

| ocuser0 |

| user0 |

skshetry · 2019-05-23T08:50:31Z

+    Given these users have been created:
+      | username |
+      | ocuser0  |
+      | ocuser1  |


Suggested change

| ocuser1 |

| user1 |

skshetry · 2019-05-23T08:50:47Z

+      | file_target | /welcome.txt |
+      | path        | /welcome.txt |
+      | permissions | 19           |
+      | uid_owner   | ocuser0      |


skshetry · 2019-05-23T08:51:33Z

+    Then the OCS status code should be "100"
+    And the HTTP status code should be "200"
+    And the fields of the last response should include
+      | share_with  | ocuser1      |


skshetry · 2019-05-23T08:51:42Z

+      | path        | /welcome.txt |
+      | permissions | 19           |
+      | uid_owner   | ocuser0      |
+    And user "ocuser1" should see the following elements


Suggested change

And user "ocuser1" should see the following elements

And user "user1" should see the following elements

individual-it · 2019-05-24T09:46:39Z

+      | file_target | /welcome.txt |
+      | path        | /welcome.txt |
+      | permissions | 19           |
+      | uid_owner   |   user0      |


please fix formating

same for other places

individual-it · 2019-05-24T09:47:44Z

+      |   user1  |
+    And group "grp1" has been created
+    And user "user1" has been added to group "grp1"
+    When user "user0" shares file "/welcome.txt" with user "USER1" using the sharing API


it would be more interesting to share with that group

Suggested change

When user "user0" shares file "/welcome.txt" with user "USER1" using the sharing API

And user "USER1" has been added to group "grp1"

When user "user0" shares file "/welcome.txt" with group "grp1" using the sharing API

phil-davis · 2019-05-28T04:05:57Z

@haribhandari07 is there an issue to go with this PR?
If not, we can create one, because there are other test combinations in user management and webUI sharing... that could have mixed user and group name scenarios.

Issue #35354

haribhandari07 · 2019-05-29T09:09:09Z

backport on #35357

individual-it requested changes May 23, 2019

View reviewed changes

individual-it requested review from dpakach, paurakhsharma and skshetry May 23, 2019 06:18

individual-it assigned haribhandari07 May 23, 2019

individual-it added 3 - To Review dev:acceptance-tests labels May 23, 2019

paurakhsharma reviewed May 23, 2019

View reviewed changes

skshetry reviewed May 23, 2019

View reviewed changes

Comment thread tests/acceptance/features/apiShareManagementBasic/createShare.feature Outdated

skshetry reviewed May 23, 2019

View reviewed changes

Comment thread tests/acceptance/features/apiShareManagementBasic/createShare.feature Outdated

skshetry reviewed May 23, 2019

View reviewed changes

Comment thread tests/acceptance/features/apiShareManagementBasic/createShare.feature Outdated

skshetry reviewed May 23, 2019

View reviewed changes

individual-it requested changes May 24, 2019

View reviewed changes

individual-it approved these changes May 27, 2019

View reviewed changes

phil-davis reviewed May 27, 2019

View reviewed changes

Comment thread tests/acceptance/features/apiShareManagementBasic/createShare.feature

api test for sharing with user by entering username in capital letters

5c15a34

phil-davis mentioned this pull request May 29, 2019

Acceptance tests for mixed case user and group names #35354

Closed

13 tasks

dpakach merged commit e4b0725 into owncloud:master May 29, 2019

haribhandari07 mentioned this pull request May 29, 2019

[Stable10] api test for sharing with user by entering username in capital letters #35357

Merged

	Scenario: share with user by entering username in capital letters
	Scenario: share with user when username contains capital letters

	And user "ocuser1" should see the following elements
	And user "user1" should see the following elements

	When user "user0" shares file "/welcome.txt" with user "USER1" using the sharing API
	And user "USER1" has been added to group "grp1"
	When user "user0" shares file "/welcome.txt" with group "grp1" using the sharing API

Uh oh!

Conversation

haribhandari07 commented May 23, 2019 • edited by phil-davis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

Open tasks:

Uh oh!

individual-it left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented May 23, 2019

Codecov Report

Uh oh!

codecov Bot commented May 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

paurakhsharma left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

phil-davis commented May 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

haribhandari07 commented May 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

haribhandari07 commented May 23, 2019 •

edited by phil-davis

Loading

codecov Bot commented May 23, 2019 •

edited

Loading

phil-davis commented May 28, 2019 •

edited

Loading