Test medial search autocompletion for accounts and groups#35313
Merged
Conversation
skshetry
force-pushed
the
groupMedialSearchAutocompletion
branch
2 times, most recently
from
May 24, 2019 07:32
cf99735 to
2cd43cd
Compare
Codecov Report
@@ Coverage Diff @@
## master #35313 +/- ##
=============================================
+ Coverage 48.87% 65.54% +16.66%
- Complexity 0 18647 +18647
=============================================
Files 109 1218 +1109
Lines 10560 70546 +59986
Branches 1288 1288
=============================================
+ Hits 5161 46236 +41075
- Misses 5022 23933 +18911
Partials 377 377
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35313 +/- ##
=========================================
Coverage 65.53% 65.53%
Complexity 18648 18648
=========================================
Files 1218 1218
Lines 70549 70549
Branches 1288 1288
=========================================
Hits 46236 46236
Misses 23936 23936
Partials 377 377
Continue to review full report at Codecov.
|
skshetry
force-pushed
the
groupMedialSearchAutocompletion
branch
from
May 24, 2019 07:36
2cd43cd to
433aecd
Compare
skshetry
changed the title
dpakach
reviewed
May 24, 2019
| And the user has browsed to the files page | ||
| And the user has opened the share dialog for folder "simple-folder" | ||
| When the user types "ce2" in the share-with-field | ||
| Then all users and groups that contain the string "finance2" in their name should be listed in the autocomplete list on the webUI |
Contributor
There was a problem hiding this comment.
Suggested change
| Then all users and groups that contain the string "finance2" in their name should be listed in the autocomplete list on the webUI | |
| Then all users and groups that contain the string "ce2" in their name should be listed in the autocomplete list on the webUI |
paurakhsharma
left a comment
paurakhsharma
left a comment
Contributor
There was a problem hiding this comment.
Scenarios look good to me.
Maybe we can move group related scenarios to webUISharingInternalGroups.
Also, we can add another step saying
user :user should be listed in the autocomplete list
But can be done in another PR.
dpakach
reviewed
May 27, 2019
Contributor
|
@paurakhsharma, yeah, I'll create a issue for that later. |
individual-it
commented
May 28, 2019
phil-davis
self-requested a review
May 30, 2019 08:37
phil-davis
approved these changes
May 30, 2019
phil-davis
force-pushed
the
groupMedialSearchAutocompletion
branch
from
May 30, 2019 09:34
4ea417a to
867286b
Compare
Contributor
|
I squashed the 7 commits into 1 just now. |
Contributor
|
Backport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a test regarding medial searches for accounts and groups.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: