cli test for polling incoming shares#35314
Conversation
9dcd548 to
5d75751
Compare
Codecov Report
@@ Coverage Diff @@
## master #35314 +/- ##
=============================================
+ Coverage 48.87% 66.57% +17.69%
- Complexity 0 18647 +18647
=============================================
Files 109 1157 +1048
Lines 10560 63268 +52708
Branches 1288 0 -1288
=============================================
+ Hits 5161 42118 +36957
- Misses 5022 21150 +16128
+ Partials 377 0 -377
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35314 +/- ##
=========================================
Coverage 65.53% 65.53%
Complexity 18648 18648
=========================================
Files 1218 1218
Lines 70548 70548
Branches 1288 1288
=========================================
Hits 46235 46235
Misses 23936 23936
Partials 377 377
Continue to review full report at Codecov.
|
5d75751 to
465cc40
Compare
phil-davis
left a comment
There was a problem hiding this comment.
I made a comment on the behaviour in one scenario, but actually it is the way the system works and IMO is OK.
| And user "user1" has been created with default attributes | ||
| And user "user1" has stored etag of element "/" | ||
| And user "user0" from server "REMOTE" has shared "/shareFolder" with user "user1" from server "LOCAL" | ||
| And user "user1" from server "LOCAL" has accepted the last pending share |
There was a problem hiding this comment.
This seems a bit weird that a user can accept a share and at that time nothing happens to "map" the shared folder into the local user's file system. But I guess that is OK - if/when the local user first lists the contents of their root folder and/or the content of the shared folder, at that time the remote share will be checked...
Co-authored-by: Dipak Acharya <dipak@jankaritech.com>
465cc40 to
c8d0841
Compare
|
@dpakach please backport |
|
Backport |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: