Skip to content

cli test for polling incoming shares#35314

Merged
individual-it merged 1 commit into
masterfrom
incomingSharesPoolTests
May 28, 2019
Merged

cli test for polling incoming shares#35314
individual-it merged 1 commit into
masterfrom
incomingSharesPoolTests

Conversation

@individual-it

@individual-it individual-it commented May 23, 2019

Copy link
Copy Markdown
Member

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov

codecov Bot commented May 24, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35314 into master will increase coverage by 17.69%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #35314       +/-   ##
=============================================
+ Coverage     48.87%   66.57%   +17.69%     
- Complexity        0    18647    +18647     
=============================================
  Files           109     1157     +1048     
  Lines         10560    63268    +52708     
  Branches       1288        0     -1288     
=============================================
+ Hits           5161    42118    +36957     
- Misses         5022    21150    +16128     
+ Partials        377        0      -377
Flag Coverage Δ Complexity Δ
#javascript ? ?
#phpunit 66.57% <ø> (+28.39%) 18647 <ø> (+18647) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/files_external/lib/config.php 10.71% <0%> (-20.87%) 19% <0%> (+19%)
core/js/oc-dialogs.js
core/js/oc-backbone.js
settings/js/admin-apps.js
core/js/config.js
core/js/sharemodel.js
core/js/files/client.js
core/js/l10n.js
core/js/js.js
core/js/systemtags/systemtags.js
... and 1162 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbd2445...5d75751. Read the comment docs.

@codecov

codecov Bot commented May 24, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35314 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35314   +/-   ##
=========================================
  Coverage     65.53%   65.53%           
  Complexity    18648    18648           
=========================================
  Files          1218     1218           
  Lines         70548    70548           
  Branches       1288     1288           
=========================================
  Hits          46235    46235           
  Misses        23936    23936           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.89% <ø> (ø) 18648 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7684118...c8d0841. Read the comment docs.

@dpakach dpakach requested review from dpakach and removed request for dpakach May 24, 2019 10:36
@skshetry skshetry changed the title cli test for polling incomming shares cli test for polling incoming shares May 24, 2019
@dpakach dpakach force-pushed the incomingSharesPoolTests branch from 5d75751 to 465cc40 Compare May 24, 2019 11:21

@phil-davis phil-davis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a comment on the behaviour in one scenario, but actually it is the way the system works and IMO is OK.

And user "user1" has been created with default attributes
And user "user1" has stored etag of element "/"
And user "user0" from server "REMOTE" has shared "/shareFolder" with user "user1" from server "LOCAL"
And user "user1" from server "LOCAL" has accepted the last pending share

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit weird that a user can accept a share and at that time nothing happens to "map" the shared folder into the local user's file system. But I guess that is OK - if/when the local user first lists the contents of their root folder and/or the content of the shared folder, at that time the remote share will be checked...

Co-authored-by: Dipak Acharya <dipak@jankaritech.com>
@individual-it individual-it force-pushed the incomingSharesPoolTests branch from 465cc40 to c8d0841 Compare May 28, 2019 06:20
@individual-it individual-it merged commit 823cac7 into master May 28, 2019
@delete-merged-branch delete-merged-branch Bot deleted the incomingSharesPoolTests branch May 28, 2019 11:45
@individual-it

Copy link
Copy Markdown
Member Author

@dpakach please backport

@phil-davis

Copy link
Copy Markdown
Contributor

Backport stable10 #35352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

acceptance tests for "occ incoming-shares:poll"

4 participants