Skip to content

Remove unnecessary create users from background in feature files for webUI tests#35356

Merged
phil-davis merged 1 commit into
masterfrom
create-user-background
May 29, 2019
Merged

Remove unnecessary create users from background in feature files for webUI tests#35356
phil-davis merged 1 commit into
masterfrom
create-user-background

Conversation

@dpakach

@dpakach dpakach commented May 29, 2019

Copy link
Copy Markdown
Contributor

Description

Remove create user steps from background for users which are not used in most of the scenarios.

Related Issue

Motivation and Context

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov

codecov Bot commented May 29, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35356 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35356   +/-   ##
=========================================
  Coverage     65.53%   65.53%           
  Complexity    18648    18648           
=========================================
  Files          1218     1218           
  Lines         70549    70549           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23936    23936           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.89% <ø> (ø) 18648 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a1858...bed7ccc. Read the comment docs.

2 similar comments
@codecov

codecov Bot commented May 29, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35356 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35356   +/-   ##
=========================================
  Coverage     65.53%   65.53%           
  Complexity    18648    18648           
=========================================
  Files          1218     1218           
  Lines         70549    70549           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23936    23936           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.89% <ø> (ø) 18648 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a1858...bed7ccc. Read the comment docs.

@codecov

codecov Bot commented May 29, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35356 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35356   +/-   ##
=========================================
  Coverage     65.53%   65.53%           
  Complexity    18648    18648           
=========================================
  Files          1218     1218           
  Lines         70549    70549           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23936    23936           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.89% <ø> (ø) 18648 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a1858...bed7ccc. Read the comment docs.

@dpakach

dpakach commented May 29, 2019

Copy link
Copy Markdown
Contributor Author

Backport on #35361

sharidas pushed a commit that referenced this pull request May 29, 2019
Remove unnecessary create users from background in feature files for webUI tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants