Skip to content

sharing with user with uppercase username#35388

Merged
phil-davis merged 1 commit into
owncloud:masterfrom
haribhandari07:webui-capital-username-share-encryption
Jun 3, 2019
Merged

sharing with user with uppercase username#35388
phil-davis merged 1 commit into
owncloud:masterfrom
haribhandari07:webui-capital-username-share-encryption

Conversation

@haribhandari07

@haribhandari07 haribhandari07 commented May 31, 2019

Copy link
Copy Markdown
Contributor

Description

acceptance test(webui) for sharing file with user with username containing uppercase letters

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@dpakach dpakach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@skshetry skshetry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@phil-davis

Copy link
Copy Markdown
Contributor

This provides a test scenario for issue #35382

Comment thread tests/acceptance/features/webUISharingInternalUsers/shareWithUsers.feature Outdated
@phil-davis

Copy link
Copy Markdown
Contributor

It got drone CI "cannot reach github.com" errors.
I restarted drone just now.

@phil-davis phil-davis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When it works properly, we expect to see lorem (2).txt because the user already has lorem.txt from their skeleton.

I ran this scenario in release-10.2.0 branch and the problem is not in that branch, so the regression has happened in some PR since 10.2.0 was released.

@codecov

codecov Bot commented May 31, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35388 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35388      +/-   ##
============================================
+ Coverage     65.53%   65.68%   +0.14%     
- Complexity    18651    18677      +26     
============================================
  Files          1221     1221              
  Lines         70555    70714     +159     
  Branches       1288     1288              
============================================
+ Hits          46236    46446     +210     
+ Misses        23942    23891      -51     
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.05% <ø> (+0.16%) 18677 <ø> (+26) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/systemtags/appinfo/app.php 14.28% <0%> (-0.35%) 0% <0%> (ø)
core/register_command.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
lib/private/DB/Connection.php 67.64% <0%> (+1.47%) 49% <0%> (ø) ⬇️
apps/dav/lib/Connector/Sabre/File.php 86.71% <0%> (+3.54%) 126% <0%> (+11%) ⬆️
core/Command/Db/ConvertType.php 38.27% <0%> (+38.27%) 56% <0%> (+15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a47a2ac...a1a4252. Read the comment docs.

@codecov

codecov Bot commented May 31, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35388 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35388   +/-   ##
=========================================
  Coverage     65.66%   65.66%           
  Complexity    18666    18666           
=========================================
  Files          1221     1221           
  Lines         70597    70597           
  Branches       1288     1288           
=========================================
  Hits          46358    46358           
  Misses        23862    23862           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.04% <ø> (ø) 18666 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6346508...b28279e. Read the comment docs.

@paurakhsharma paurakhsharma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@phil-davis phil-davis merged commit 666e084 into owncloud:master Jun 3, 2019
@phil-davis

Copy link
Copy Markdown
Contributor

@haribhandari07 please backport to stable10

@haribhandari07

Copy link
Copy Markdown
Contributor Author

Backport on #35409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants