Skip to content

apiShareManagementBasic don't use skeleton files when not required#35392

Merged
phil-davis merged 1 commit into
masterfrom
apiShareManagementBasic-use-no-skeleton-step
Jun 4, 2019
Merged

apiShareManagementBasic don't use skeleton files when not required#35392
phil-davis merged 1 commit into
masterfrom
apiShareManagementBasic-use-no-skeleton-step

Conversation

@paurakhsharma

Copy link
Copy Markdown
Contributor

Description

Don't user skeleton files when not required

Related Issue

owncloud/QA#621

Motivation and Context

  • Make CI faster in scenarios where there is no need for user files.

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@codecov

codecov Bot commented May 31, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35392 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #35392   +/-   ##
=======================================
  Coverage   48.87%   48.87%           
=======================================
  Files         109      109           
  Lines       10560    10560           
  Branches     1288     1288           
=======================================
  Hits         5161     5161           
  Misses       5022     5022           
  Partials      377      377
Flag Coverage Δ
#javascript 53.69% <ø> (ø) ⬆️
#phpunit 38.17% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a4e13d...35cb7f0. Read the comment docs.

@codecov

codecov Bot commented May 31, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35392 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35392   +/-   ##
=========================================
  Coverage     65.66%   65.66%           
  Complexity    18666    18666           
=========================================
  Files          1221     1221           
  Lines         70597    70597           
  Branches       1288     1288           
=========================================
  Hits          46358    46358           
  Misses        23862    23862           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.04% <ø> (ø) 18666 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6346508...d6c0c95. Read the comment docs.

@paurakhsharma paurakhsharma force-pushed the apiShareManagementBasic-use-no-skeleton-step branch from 35cb7f0 to d6c0c95 Compare June 3, 2019 05:43

@phil-davis phil-davis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis phil-davis changed the title apiShareManagementBasic don't user skeleton files when not required apiShareManagementBasic don't use skeleton files when not required Jun 4, 2019
@phil-davis phil-davis merged commit 99cec72 into master Jun 4, 2019
@delete-merged-branch delete-merged-branch Bot deleted the apiShareManagementBasic-use-no-skeleton-step branch June 4, 2019 15:14
@phil-davis

Copy link
Copy Markdown
Contributor

Backport stable10 #35428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants