Do not use skeleton file when not required by dpakach · Pull Request #35405 · owncloud/core

dpakach · 2019-06-03T07:17:08Z

Description

Do not use skeleton folder for webUIAcceptShare and webUIAdminSettings suites to speed up CI.

Related Issue

~~Fixes~~ Part of speed-up CI QA#621

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Database schema changes (next release will require increase of minor version instead of patch)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests only (no source changes)

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

Open tasks:

Backport (if applicable set "backport-request" label and remove when the backport was done)

codecov · 2019-06-03T08:49:56Z

Codecov Report

Merging #35405 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #35405   +/-   ##
=========================================
  Coverage     65.66%   65.66%           
  Complexity    18666    18666           
=========================================
  Files          1221     1221           
  Lines         70597    70597           
  Branches       1288     1288           
=========================================
  Hits          46358    46358           
  Misses        23862    23862           
  Partials        377      377

Flag	Coverage Δ	Complexity Δ
#javascript	`53.69% <ø> (ø)`	`0 <ø> (ø)`	⬇️
#phpunit	`67.04% <ø> (ø)`	`18666 <ø> (ø)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 647525b...1f60a93. Read the comment docs.

codecov · 2019-06-03T08:50:01Z

Codecov Report

Merging #35405 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #35405   +/-   ##
=========================================
  Coverage     65.66%   65.66%           
  Complexity    18666    18666           
=========================================
  Files          1221     1221           
  Lines         70597    70597           
  Branches       1288     1288           
=========================================
  Hits          46358    46358           
  Misses        23862    23862           
  Partials        377      377

Flag	Coverage Δ	Complexity Δ
#javascript	`53.69% <ø> (ø)`	`0 <ø> (ø)`	⬇️
#phpunit	`67.04% <ø> (ø)`	`18666 <ø> (ø)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99cec72...9904457. Read the comment docs.

paurakhsharma · 2019-06-03T11:12:06Z

-      | username |
-      | user1    |
-      | user2    |
+#    Given these users have been created with default attributes:


Oops, forgot to remove comments

paurakhsharma

Please have a look at the comments.

paurakhsharma · 2019-06-03T11:16:54Z

+      | /simple-folder/from_user1/       |
+      | /simple-folder%20(2)/from_user2/ |

  Scenario: receive shares with same name from different users


This scenario is the same as the scenario in line 33. Is there a special reason for this?

phil-davis · 2019-06-04T11:24:40Z

Backport stable10 #35424

phil-davis · 2019-06-04T11:40:01Z

Rebased to get good CI

phil-davis · 2019-06-04T15:27:35Z

It got a dumb composer error in drone https://drone.owncloud.com/owncloud/core/18013/830
I will rebase again so it restarts CI.

phil-davis · 2019-06-05T06:17:31Z

No code coverage result has come. I have rebased and force-pushed again. Maybe it will come next time?

dpakach requested review from paurakhsharma and skshetry June 3, 2019 08:01

dpakach self-assigned this Jun 3, 2019

dpakach added backport-request dev:acceptance-tests QA:team 3 - To Review labels Jun 3, 2019

dpakach marked this pull request as ready for review June 3, 2019 08:02

paurakhsharma reviewed Jun 3, 2019

View reviewed changes

paurakhsharma mentioned this pull request Jun 3, 2019

Add steps with no skeleton dir wherever possible. owncloud/QA#622

Closed

19 tasks

dpakach force-pushed the not-use-skeleton-file branch from 1f60a93 to 822563c Compare June 3, 2019 11:34

dpakach requested review from individual-it and phil-davis June 3, 2019 11:34

individual-it approved these changes Jun 4, 2019

View reviewed changes

dpakach mentioned this pull request Jun 4, 2019

[Stable10] Do not use skeleton file when not required #35424

Merged

phil-davis removed the backport-request label Jun 4, 2019

phil-davis force-pushed the not-use-skeleton-file branch from 822563c to 5f82c4e Compare June 4, 2019 11:39

phil-davis force-pushed the not-use-skeleton-file branch from 5f82c4e to 9904457 Compare June 4, 2019 15:34

phil-davis added 4 - To release and removed 3 - To Review labels Jun 4, 2019

phil-davis force-pushed the not-use-skeleton-file branch from 9904457 to c8b5ae6 Compare June 5, 2019 04:37

Do not use skeleton file when not required

0138945

phil-davis force-pushed the not-use-skeleton-file branch from c8b5ae6 to 0138945 Compare June 5, 2019 06:17

DeepDiver1975 merged commit db70679 into master Jun 5, 2019

delete-merged-branch Bot deleted the not-use-skeleton-file branch June 5, 2019 07:56

individual-it mentioned this pull request Sep 24, 2019

skeleton folder for acceptance tests owncloud/QA#628

Closed

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Do not use skeleton file when not required#35405

Do not use skeleton file when not required#35405
DeepDiver1975 merged 1 commit into
masterfrom
not-use-skeleton-file

dpakach commented Jun 3, 2019 •

edited by individual-it

Loading

Uh oh!

codecov Bot commented Jun 3, 2019

Uh oh!

codecov Bot commented Jun 3, 2019 •

edited

Loading

Uh oh!

paurakhsharma Jun 3, 2019

Uh oh!

paurakhsharma left a comment

Uh oh!

paurakhsharma Jun 3, 2019

Uh oh!

phil-davis commented Jun 4, 2019

Uh oh!

phil-davis commented Jun 4, 2019

Uh oh!

phil-davis commented Jun 4, 2019

Uh oh!

phil-davis commented Jun 5, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

dpakach commented Jun 3, 2019 • edited by individual-it Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Open tasks:

Uh oh!

codecov Bot commented Jun 3, 2019

Codecov Report

Uh oh!

codecov Bot commented Jun 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

paurakhsharma Jun 3, 2019

Choose a reason for hiding this comment

Uh oh!

paurakhsharma left a comment

Choose a reason for hiding this comment

Uh oh!

paurakhsharma Jun 3, 2019

Choose a reason for hiding this comment

Uh oh!

phil-davis commented Jun 4, 2019

Uh oh!

phil-davis commented Jun 4, 2019

Uh oh!

phil-davis commented Jun 4, 2019

Uh oh!

phil-davis commented Jun 5, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dpakach commented Jun 3, 2019 •

edited by individual-it

Loading

codecov Bot commented Jun 3, 2019 •

edited

Loading