Skip to content

Split webUISharingInternalUsers into two suites#35408

Merged
dpakach merged 1 commit into
masterfrom
split-suite-webuisharinginternalUser
Jun 4, 2019
Merged

Split webUISharingInternalUsers into two suites#35408
dpakach merged 1 commit into
masterfrom
split-suite-webuisharinginternalUser

Conversation

@dpakach

@dpakach dpakach commented Jun 3, 2019

Copy link
Copy Markdown
Contributor

Description

Split acceptance test suite webUISharingInternalUsers into two suites.

Related Issue

Motivation and Context

This suite contains features regarding share autocompletion and share with users. These are unrelated features and contain large number of scenarios and required a lot of time to complete in CI. So they needed to be split into their respective suites.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@dpakach
dpakach requested review from paurakhsharma and skshetry June 3, 2019 08:47
@dpakach dpakach self-assigned this Jun 3, 2019
skshetry
skshetry reviewed Jun 3, 2019
View reviewed changes

@skshetry skshetry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests pass, 👍

paurakhsharma
paurakhsharma reviewed Jun 3, 2019
View reviewed changes
Comment thread .drone.yml Outdated
CHOWN_SERVER: true
OWNCLOUD_LOG: true
INSTALL_TESTING_APP: true
USE_EMAIL: true

@paurakhsharma paurakhsharma Jun 3, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Email is not required here.

paurakhsharma
paurakhsharma reviewed Jun 3, 2019
View reviewed changes
Comment thread tests/acceptance/config/behat.yml Outdated
- WebUIGeneralContext:
- WebUILoginContext:
- WebUISharingContext:
- EmailContext:

@paurakhsharma paurakhsharma Jun 3, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Email is not required here.

@dpakach
dpakach force-pushed the split-suite-webuisharinginternalUser branch from 4febfab to 0046a67 Compare June 3, 2019 10:33
@codecov

codecov Bot commented Jun 3, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35408 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35408   +/-   ##
=========================================
  Coverage     65.66%   65.66%           
  Complexity    18666    18666           
=========================================
  Files          1221     1221           
  Lines         70597    70597           
  Branches       1288     1288           
=========================================
  Hits          46358    46358           
  Misses        23862    23862           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.04% <ø> (ø) 18666 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 666e084...0046a67. Read the comment docs.

@codecov

codecov Bot commented Jun 3, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #35408 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35408   +/-   ##
=========================================
  Coverage     65.66%   65.66%           
  Complexity    18666    18666           
=========================================
  Files          1221     1221           
  Lines         70597    70597           
  Branches       1288     1288           
=========================================
  Hits          46358    46358           
  Misses        23862    23862           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.04% <ø> (ø) 18666 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fef563f...160d1fe. Read the comment docs.

paurakhsharma
paurakhsharma reviewed Jun 3, 2019
View reviewed changes

@paurakhsharma paurakhsharma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@phil-davis

phil-davis commented Jun 3, 2019

Copy link
Copy Markdown
Contributor

user_ldap will need to know about the new suite tomorrow

@dpakach dpakach mentioned this pull request Jun 3, 2019
Merged
@phil-davis

phil-davis commented Jun 3, 2019

Copy link
Copy Markdown
Contributor

Backport stable10 #35411

@phil-davis
phil-davis force-pushed the split-suite-webuisharinginternalUser branch from 0046a67 to 160d1fe Compare June 4, 2019 11:38
@phil-davis

phil-davis commented Jun 4, 2019

Copy link
Copy Markdown
Contributor

Rebased to get good CI

@dpakach
dpakach merged commit 93552b4 into master Jun 4, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the split-suite-webuisharinginternalUser branch June 4, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes
@individual-it individual-it Awaiting requested review from individual-it
+2 more reviewers
@skshetry skshetry skshetry left review comments
@paurakhsharma paurakhsharma paurakhsharma left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@dpakach dpakach

Labels

4 - To release dev:acceptance-tests QA:team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

speed-up CI

4 participants

@dpakach @phil-davis @skshetry @paurakhsharma