Use skeleton files only when necessary in webuiCreateDelete and webUISharingIntGrp suites#35421
Merged
Merged
Conversation
dpakach
requested review from
paurakhsharma and
skshetry
and removed request for
skshetry
June 4, 2019 10:27
phil-davis
reviewed
Jun 4, 2019
| @@ -41,6 +41,8 @@ Feature: create folder | |||
| Scenario Outline: Create a sub-folder inside an existing folder with problematic name | |||
| # Use an existing folder with problematic name to create a sub-folder | |||
| # Uses the folder created by skeleton | |||
Contributor
There was a problem hiding this comment.
this comment is not true now
dpakach
force-pushed
the
webuiSharingInternalGrp-skelton
branch
from
June 4, 2019 11:26
f8db57e to
5c3c82a
Compare
Codecov Report
@@ Coverage Diff @@
## master #35421 +/- ##
=========================================
Coverage 65.66% 65.66%
Complexity 18666 18666
=========================================
Files 1221 1221
Lines 70597 70597
Branches 1288 1288
=========================================
Hits 46358 46358
Misses 23862 23862
Partials 377 377
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35421 +/- ##
=========================================
Coverage 65.66% 65.66%
Complexity 18666 18666
=========================================
Files 1221 1221
Lines 70597 70597
Branches 1288 1288
=========================================
Hits 46358 46358
Misses 23862 23862
Partials 377 377
Continue to review full report at Codecov.
|
phil-davis
approved these changes
Jun 4, 2019
Contributor
Author
|
backport #35425 |
…SharingIntGrp suites
phil-davis
force-pushed
the
webuiSharingInternalGrp-skelton
branch
from
June 4, 2019 12:53
5c3c82a to
1d23f0e
Compare
Contributor
|
Rebased to get good CI |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the usage of skeleton in acceptance test suites
webUICreateDeleteandwebUISharingInternalGroupswhen the skeleton files are not required.Related Issue
Motivation and Context
The tests in CI take forever to complete. So to speed them up minimize the use of skeleton files.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: