Skip to content

[stable10] web ui restrict sharing use no skeleton #35481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phil-davis merged 1 commit into from
Jun 11, 2019
Merged

[stable10] web ui restrict sharing use no skeleton #35481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/acceptance/features/webUIRestrictSharing/disableSharing.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,12 @@ Feature: disable sharing
So that users cannot share files

Background:
Given user "user1" has been created with default attributes and skeleton files
Given user "user1" has been created with default attributes and without skeleton files

@TestAlsoOnExternalUserBackend
@smokeTest
Scenario: Users tries to share via WebUI when Sharing is disabled
Given the setting "Allow apps to use the Share API" in the section "Sharing" has been disabled
Given user "user1" has created folder "simple-folder"
And the setting "Allow apps to use the Share API" in the section "Sharing" has been disabled
When user "user1" logs in using the webUI
Then it should not be possible to share folder "simple-folder" using the webUI
4 changes: 3 additions & 1 deletion tests/acceptance/features/webUIRestrictSharing/restrictReSharing.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Feature: restrict resharing
I want to be able to forbid a user that received a share from me to share it further

Background:
Given these users have been created with default attributes and skeleton files:
Given these users have been created with default attributes and without skeleton files:
| username |
| user1 |
| user2 |
Expand All @@ -15,6 +15,8 @@ Feature: restrict resharing
| grp1 |
And user "user1" has been added to group "grp1"
And user "user2" has been added to group "grp1"
And user "user1" has created folder "simple-folder"
And user "user2" has created folder "simple-folder"
And user "user2" has logged in using the webUI

@skipOnMICROSOFTEDGE @TestAlsoOnExternalUserBackend
Expand Down
11 changes: 7 additions & 4 deletions tests/acceptance/features/webUIRestrictSharing/restrictSharing.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,18 @@ Feature: restrict Sharing
So that users can only share files with specific users and groups

Background:
Given these users have been created with default attributes and skeleton files:
Given these users have been created with default attributes and without skeleton files:
| username |
| user1 |
| user2 |
| user3 |
And these groups have been created:
| groupname |
| grp1 |
| grp2 |
And user "user1" has been added to group "grp1"
And user "user2" has been added to group "grp1"
And user "user3" has been added to group "grp2"
And user "user1" has created folder "simple-folder"
And user "user2" has created folder "simple-folder"
And user "user2" has logged in using the webUI

@TestAlsoOnExternalUserBackend
Expand All @@ -41,7 +41,10 @@ Feature: restrict Sharing

@TestAlsoOnExternalUserBackend
Scenario: Do not restrict users to only share with groups they are member of
Given the setting "Restrict users to only share with groups they are member of" in the section "Sharing" has been disabled
Given user "user3" has been created with default attributes and without skeleton files
And user "user3" has been added to group "grp2"
And user "user3" has created folder "simple-folder"
And the setting "Restrict users to only share with groups they are member of" in the section "Sharing" has been disabled
And the user browses to the files page
When the user shares folder "simple-folder" with group "grp2" using the webUI
And the user re-logs in as "user3" using the webUI
Expand Down