webui tag operations without skeleton#35493
Conversation
dpakach
requested review from
dpakach,
individual-it,
paurakhsharma,
phil-davis and
skshetry
Codecov Report
@@ Coverage Diff @@
## master #35493 +/- ##
=========================================
Coverage 65.68% 65.68%
Complexity 18735 18735
=========================================
Files 1221 1221
Lines 70793 70793
Branches 1288 1288
=========================================
Hits 46503 46503
Misses 23913 23913
Partials 377 377
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #35493 +/- ##
=========================================
Coverage 65.68% 65.68%
Complexity 18735 18735
=========================================
Files 1221 1221
Lines 70793 70793
Branches 1288 1288
=========================================
Hits 46503 46503
Misses 23913 23913
Partials 377 377
Continue to review full report at Codecov.
|
individual-it
left a comment
individual-it
left a comment
There was a problem hiding this comment.
mostly good, just one small issue
| And the user has created a "normal" tag with name "random" | ||
| And the user has added tag "random" to file "randomfile.txt" | ||
| And the user has added tag "random" to file "randomfile-big.txt" | ||
| And the user has browsed directly to display the details of file "randomfile.txt" in folder "" |
There was a problem hiding this comment.
in the original test a file in a subfolder is used here, so 3 different files are used, not only 2
There was a problem hiding this comment.
PR is already merged. @haribhandari07 please sort this out with @individual-it and make another PR to adjust.
| Then file "simple-folder/lorem.txt" should have no tags for user "user1" | ||
| Given user "user1" has created folder "a-folder" | ||
| And user "user1" has uploaded file with content "some content" to "/a-folder/randomfile.txt" | ||
| And the user has created a "normal" tag with name "random" |
There was a problem hiding this comment.
👍 very good, we don't want to have webUI steps in Given
|
Backport on #35497 |
4 participants
Description
Do not use skeleton files for
webUITagsto speed up CIRelated Issue
Part of owncloud/QA#622
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: