Skip to content

webUIComments without skeleton#35500

Merged
paurakhsharma merged 1 commit into
masterfrom
webUIComments-no-skeleton
Jun 13, 2019
Merged

webUIComments without skeleton#35500
paurakhsharma merged 1 commit into
masterfrom
webUIComments-no-skeleton

Conversation

@paurakhsharma

Copy link
Copy Markdown
Contributor

Description

Don't user skeleton files on webUIComments

Related Issue

owncloud/QA#621

Motivation and Context

  • Make CI faster in scenarios where there is no need for user files.

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@dpakach dpakach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@paurakhsharma

Copy link
Copy Markdown
Contributor Author

Backport on: #35504

@individual-it

Copy link
Copy Markdown
Member

no code coverage, restrting build

@codecov

codecov Bot commented Jun 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35500 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35500   +/-   ##
=========================================
  Coverage     65.68%   65.68%           
  Complexity    18735    18735           
=========================================
  Files          1221     1221           
  Lines         70793    70793           
  Branches       1288     1288           
=========================================
  Hits          46503    46503           
  Misses        23913    23913           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.06% <ø> (ø) 18735 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aba41b...cafaaae. Read the comment docs.

@paurakhsharma paurakhsharma merged commit 4e51c0c into master Jun 13, 2019
@delete-merged-branch delete-merged-branch Bot deleted the webUIComments-no-skeleton branch June 13, 2019 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants