Skip to content

Use no skeleton on webUIFavorites#35502

Merged
DeepDiver1975 merged 1 commit into
masterfrom
webUIFavorites-no-skelton
Jun 13, 2019
Merged

Use no skeleton on webUIFavorites#35502
DeepDiver1975 merged 1 commit into
masterfrom
webUIFavorites-no-skelton

Conversation

@paurakhsharma

Copy link
Copy Markdown
Contributor

Description

Don't user skeleton files on webUIFavorites

Related Issue

owncloud/QA#621

Motivation and Context

  • Make CI faster in scenarios where there is no need for user files.

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@paurakhsharma paurakhsharma self-assigned this Jun 12, 2019
@paurakhsharma paurakhsharma changed the title Use no skeleton on webUIComments Use no skeleton on webUIFavorites Jun 12, 2019
@paurakhsharma
paurakhsharma force-pushed the webUIFavorites-no-skelton branch from 4085af0 to 2e87c71 Compare June 13, 2019 10:27
@codecov

codecov Bot commented Jun 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35502 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35502      +/-   ##
============================================
- Coverage     65.93%   65.68%   -0.26%     
  Complexity    18735    18735              
============================================
  Files          1160     1221      +61     
  Lines         63470    70793    +7323     
  Branches          0     1288    +1288     
============================================
+ Hits          41852    46503    +4651     
- Misses        21618    23913    +2295     
- Partials          0      377     +377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (?) 0 <ø> (?)
#phpunit 67.06% <ø> (+1.12%) 18735 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 81.09% <0%> (-8.47%) 0% <0%> (ø)
core/js/oc-dialogs.js 2.66% <0%> (ø) 0% <0%> (?)
core/js/oc-backbone.js 50% <0%> (ø) 0% <0%> (?)
settings/js/admin-apps.js 6.46% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/external.js 77.96% <0%> (ø) 0% <0%> (?)
apps/comments/js/commentmodel.js 100% <0%> (ø) 0% <0%> (?)
core/js/l10n.js 90.54% <0%> (ø) 0% <0%> (?)
core/js/js.js 55.05% <0%> (ø) 0% <0%> (?)
core/js/systemtags/systemtags.js 90% <0%> (ø) 0% <0%> (?)
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab8d8e9...2e87c71. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Jun 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35502 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35502      +/-   ##
============================================
- Coverage     65.93%   65.68%   -0.26%     
  Complexity    18735    18735              
============================================
  Files          1160     1221      +61     
  Lines         63470    70793    +7323     
  Branches          0     1288    +1288     
============================================
+ Hits          41852    46503    +4651     
- Misses        21618    23913    +2295     
- Partials          0      377     +377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (?) 0 <ø> (?)
#phpunit 67.06% <ø> (+1.12%) 18735 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 81.09% <0%> (-8.47%) 0% <0%> (ø)
core/js/oc-dialogs.js 2.66% <0%> (ø) 0% <0%> (?)
core/js/oc-backbone.js 50% <0%> (ø) 0% <0%> (?)
settings/js/admin-apps.js 6.46% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/external.js 77.96% <0%> (ø) 0% <0%> (?)
apps/comments/js/commentmodel.js 100% <0%> (ø) 0% <0%> (?)
core/js/l10n.js 90.54% <0%> (ø) 0% <0%> (?)
core/js/js.js 55.05% <0%> (ø) 0% <0%> (?)
core/js/systemtags/systemtags.js 90% <0%> (ø) 0% <0%> (?)
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab8d8e9...2e87c71. Read the comment docs.

@paurakhsharma

Copy link
Copy Markdown
Contributor Author

Backport on: #35529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants