Skip to content

Use no skeleton files on webUIPersonalSettings#35511

Merged
DeepDiver1975 merged 1 commit into
masterfrom
webUIPersonalSettings-no-skeleton
Jun 17, 2019
Merged

Use no skeleton files on webUIPersonalSettings#35511
DeepDiver1975 merged 1 commit into
masterfrom
webUIPersonalSettings-no-skeleton

Conversation

@paurakhsharma

Copy link
Copy Markdown
Contributor

Description

Don't user skeleton files on webUIPersonalSettings

Related Issue

owncloud/QA#622

Motivation and Context

  • Make CI faster in scenarios where there is no need for user files.

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Comment thread tests/acceptance/features/webUIPersonalSettings/personalGeneralSettings.feature Outdated
@paurakhsharma
paurakhsharma force-pushed the webUIPersonalSettings-no-skeleton branch from 1e834e4 to c8aadf1 Compare June 13, 2019 08:33
@codecov

codecov Bot commented Jun 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35511 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35511      +/-   ##
============================================
- Coverage     65.93%   65.68%   -0.26%     
  Complexity    18735    18735              
============================================
  Files          1160     1221      +61     
  Lines         63470    70793    +7323     
  Branches          0     1288    +1288     
============================================
+ Hits          41852    46503    +4651     
- Misses        21618    23913    +2295     
- Partials          0      377     +377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (?) 0 <ø> (?)
#phpunit 67.06% <ø> (+1.12%) 18735 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 81.09% <0%> (-8.47%) 0% <0%> (ø)
core/js/oc-dialogs.js 2.66% <0%> (ø) 0% <0%> (?)
core/js/oc-backbone.js 50% <0%> (ø) 0% <0%> (?)
settings/js/admin-apps.js 6.46% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/external.js 77.96% <0%> (ø) 0% <0%> (?)
apps/comments/js/commentmodel.js 100% <0%> (ø) 0% <0%> (?)
core/js/l10n.js 90.54% <0%> (ø) 0% <0%> (?)
core/js/js.js 55.05% <0%> (ø) 0% <0%> (?)
core/js/systemtags/systemtags.js 90% <0%> (ø) 0% <0%> (?)
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab8d8e9...c8aadf1. Read the comment docs.

@codecov

codecov Bot commented Jun 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35511 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35511   +/-   ##
=========================================
  Coverage     65.66%   65.66%           
  Complexity    18756    18756           
=========================================
  Files          1222     1222           
  Lines         70872    70872           
  Branches       1289     1289           
=========================================
  Hits          46540    46540           
  Misses        23954    23954           
  Partials        378      378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.03% <ø> (ø) 18756 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67f7273...7f346fa. Read the comment docs.

@paurakhsharma

Copy link
Copy Markdown
Contributor Author

Agh, codecov failed. Will restart the build.

@paurakhsharma
paurakhsharma force-pushed the webUIPersonalSettings-no-skeleton branch from c8aadf1 to 3672e2f Compare June 13, 2019 10:29

@phil-davis phil-davis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 more "png" references. They do not break the test scenarios, but they will confuse people who read these scenarios.

Comment thread tests/acceptance/features/webUIPersonalSettings/personalGeneralSettings.feature Outdated
Comment thread tests/acceptance/features/webUIPersonalSettings/personalGeneralSettings.feature Outdated
@paurakhsharma
paurakhsharma force-pushed the webUIPersonalSettings-no-skeleton branch from 3672e2f to b565efa Compare June 14, 2019 05:16
@paurakhsharma
paurakhsharma requested a review from phil-davis June 14, 2019 05:21
@paurakhsharma

Copy link
Copy Markdown
Contributor Author

Backport on: #35527

@phil-davis
phil-davis force-pushed the webUIPersonalSettings-no-skeleton branch from b565efa to 687bbf6 Compare June 14, 2019 06:53
@phil-davis

Copy link
Copy Markdown
Contributor

I rebased - maybe we will get codecov status this time?

@paurakhsharma
paurakhsharma force-pushed the webUIPersonalSettings-no-skeleton branch from 4831046 to 7f346fa Compare June 17, 2019 05:31
@paurakhsharma

Copy link
Copy Markdown
Contributor Author

Still no codecov 😨

@DeepDiver1975
DeepDiver1975 merged commit fc3547a into master Jun 17, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the webUIPersonalSettings-no-skeleton branch June 17, 2019 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants